Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat: Salesloft) - Add emails_scoped_fields stream #55229

Merged
merged 5 commits into from
Mar 10, 2025
Merged

(feat: Salesloft) - Add emails_scoped_fields stream #55229

merged 5 commits into from
Mar 10, 2025

Conversation

tybernstein
Copy link
Contributor

Adds a new stream which is the same as the emails stream with the addition of the scoped_fields: body and subject. These fields require a specific Salesloft plan and are not available to everyone which is why they are on their own stream. Removes body and subject fields from emails stream schema as they are null without the required parameters added to the request.

What

Fixes #55221

How

Adds a new stream with the required query parameter scoped_fields[]: ["subject","body"]

Review guide

User Impact

By using a new dedicated stream it should not impact existing users. Potential negative impact is that the new stream is only available for specific Salesloft plans

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@tybernstein
Add emails_scoped_fields stream
373950b 
Adds a new stream which is the same as the emails stream with the addition of the scoped_fields: body and subject. These fields require a specific Salesloft plan and are not available to everyone which is why they are on their own stream
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 3:26pm

@tybernstein
Update salesloft.md
226db01 
Add docs for new stream and update changelog
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 6, 2025
@tybernstein tybernstein requested a review from agarctfi March 6, 2025 15:16
@tybernstein tybernstein marked this pull request as ready for review March 6, 2025 15:17
@agarctfi agarctfi changed the title Add emails_scoped_fields stream (feat: Salesloft) - Add emails_scoped_fields stream Mar 6, 2025
@tybernstein tybernstein mentioned this pull request Mar 6, 2025
Closed
1 task
@agarctfi agarctfi requested a review from a team March 6, 2025 15:48
@agarctfi
Copy link
Contributor

agarctfi commented Mar 6, 2025

@airbytehq/dev-extensibility I added my comments, but I think this looks good!

@natikgadzhi natikgadzhi merged commit 3f3eba3 into master Mar 10, 2025
30 checks passed
@natikgadzhi natikgadzhi deleted the tybernstein-patch-1 branch March 10, 2025 17:06
sc250072 added a commit to Teradata/airbyte that referenced this pull request Mar 14, 2025
@github-actions @maxi297
@johnny-schmidt @tautvydas-v @ian-at-airbyte @topefolorunso @octavia-squidington-iii @natikgadzhi @aaronsteers @tybernstein @kyleromines @artem1205 @tolik0 @aldogonzalez8 @pabloescoder @h0rban @marcosmarxm @btkcodedev @devin-ai-integration @jdpgrailsdev @frifriSF59 @pnilan @agarctfi @dependabot @suhl79 @sc250072 @sheyd @mwbayley @edgao @matteogp @burakku @theyueli
Fork Sync: Update from parent repository (#129)
5e5a3a3 
* ✨ Source Intercom: adding a mock server test (airbytehq#54715)

* [Destination MS SQL V2] Correct Part Size, No buffered input stream (airbytehq#55252)

* [source-hibob] Changed check stream from payrolls to profiles airbytehq#55674 (airbytehq#55675)

* Add llms.txt to docs.airbyte.com (airbytehq#55261)

* ✨ TikTok Marketing Source: Add `Pixels`, `PixelInstantPageEvents`, `PixelEventsStatistics` streams (airbytehq#55669)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* chore(ci): remove stale and unused workflows (airbytehq#55260)

* ci: for community CI, rename 'early ci' to 'pre-release checks', skip duplicated tests in 'connector tests' (airbytehq#55241)

* (feat: Salesloft) - Add emails_scoped_fields stream (airbytehq#55229)

* 🐛 Source Outreach: remove stream_state interpolation (airbytehq#55180)

Co-authored-by: Natik Gadzhi <natik@respawn.io>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* fix(source-stripe): disable progressive rollout (airbytehq#55682)

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>

* fix(source-instagram): Disable cache for InstagramMediaChildrenTransformation (airbytehq#55685)

* [Destination MSSQL V2] Bulk Load Local Performance Test (airbytehq#55687)

* [Destination-S3] File Xfer Local Performance Test (airbytehq#55220)

* 🐛bug(source-hubspot): fix deals_archived and marketing_emails issues for CAT (airbytehq#54177)

* ✨Source Quickbooks: Migrate to manifest-only (airbytehq#55263)

* ✨ Source Zendesk Chat : Migrate to Manifest-only (airbytehq#47319)

* ✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream (airbytehq#50418)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>

* Source Sendgrid: Update manifest for adapting changes with AsyncRetriever (airbytehq#55185)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* docs: fix broken markup in Python CDK Basic Concepts page (airbytehq#55699)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: natik@airbyte.io <natik@airbyte.io>

* Source Zendesk Talk : Restore Unit Test (airbytehq#50956)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Natik Gadzhi <natik@respawn.io>

* chore: 2.0.0 release (airbytehq#55684)

* Adding EnrichedAirbyteValue and DeclaredField (airbytehq#55218)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* Add Airbyte Academy section (airbytehq#49964)

* [source-faker] - Bump to stable 6.2.21 (airbytehq#55705)

* fix: remove duplicate breaking changes from destination-mssql metadata (airbytehq#55718)

* fix: restore definition ID (airbytehq#55720)

* ✨ Source Freshdesk : Migrate to Manifest-only (airbytehq#54687)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* chore(source-s3): update base image to 4.0.0 and use caret dependencies (do not merge) (airbytehq#55202)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: natik@airbyte.io <natik@airbyte.io>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Aldo Gonzalez <aldo.gonzalez@airbyte.io>

* fix(Source-LinkedIn-Ads): Update outdated schema (airbytehq#55724)

* Bump @babel/runtime-corejs3 from 7.23.6 to 7.26.10 in /docusaurus (airbytehq#55708)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 🐛 Source S3: Up CDK to fix schema type issue (airbytehq#55694)

* source-shipstation contribution from suhl79 (airbytehq#55738)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>

* destination-teradata: Upgrade JDBC driver (airbytehq#55183)

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>

* 🐛 Destination Databricks: Fix destination check test table collisions when multiple connections write to same schema. (airbytehq#55232)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* (source-sendgrid) - Configure max concurrent async job count (airbytehq#55744)

* pass streams to debezium sources on cold start (airbytehq#55734)

* Destination S3 Data Lake: exclude invalid fields from identifier fields (airbytehq#55700)

* [source-mysql] pin to cdk 0.342 (airbytehq#55754)

* docs: add enterprise connector documentation (airbytehq#55751)

* Add UTM source (airbytehq#55733)

* Matteogp/docs sap hana update 1 (airbytehq#55696)

* Destination S3 Data Lake: Handle number in primary key (airbytehq#55755)

* Fix reversed assertions in MySQL source tests (airbytehq#55756)

* Update CDK to pass DestinationRecordRaw around (airbytehq#55737)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>

* fix(ci): remove empty notify-on-push workflow file (airbytehq#55757)

* Update OTEL metrics, add new linting exceptions (airbytehq#55752)

* 11526 second pass through iceberg documentation (airbytehq#55736)

* [source-mysql] don't do sampling for source-mysql (airbytehq#55761)

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* 🚨Source Fauna: Migrate to poetry (airbytehq#41051)

---------

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Maxime Carbonneau-Leclerc <3360483+maxi297@users.noreply.github.com>
Co-authored-by: Johnny Schmidt <john.schmidt@airbyte.io>
Co-authored-by: tautvydas-v <127105313+tautvydas-v@users.noreply.github.com>
Co-authored-by: Ian Alton <ian.alton@airbyte.io>
Co-authored-by: Tope Folorunso <66448986+topefolorunso@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Natik Gadzhi <natik@respawn.io>
Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: Tyler B <104733644+tybernstein@users.noreply.github.com>
Co-authored-by: kyleromines <163910384+kyleromines@users.noreply.github.com>
Co-authored-by: Artem Inzhyyants <36314070+artem1205@users.noreply.github.com>
Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com>
Co-authored-by: Aldo Gonzalez <168454423+aldogonzalez8@users.noreply.github.com>
Co-authored-by: Dhroov Makwana <pabloescoder@gmail.com>
Co-authored-by: jake horban <j@portal.ai>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: btkcodedev <btk.codedev@gmail.com>
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: natik@airbyte.io <natik@airbyte.io>
Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io>
Co-authored-by: Francis Genet <francis.genet@airbyte.io>
Co-authored-by: Patrick Nilan <nilan.patrick@gmail.com>
Co-authored-by: Aldo Gonzalez <aldo.gonzalez@airbyte.io>
Co-authored-by: Alfredo Garcia <alfredo.garcia@hallmark.edu>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: suhl79 <45366124+suhl79@users.noreply.github.com>
Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com>
Co-authored-by: Sena Heydari <sheyd@users.noreply.github.com>
Co-authored-by: Matt Bayley <31358253+mwbayley@users.noreply.github.com>
Co-authored-by: Edward Gao <edward.gao@airbyte.io>
Co-authored-by: Matteo Palarchio <20643714+matteogp@users.noreply.github.com>
Co-authored-by: Wenqi Hu <wenqi.huu@gmail.com>
Co-authored-by: Yue Li <61070669+theyueli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarctfi agarctfi agarctfi left review comments

@natikgadzhi natikgadzhi natikgadzhi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesloft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[source-salesloft] not returning scoped fields
4 participants
@tybernstein @agarctfi @natikgadzhi @octavia-squidington-iii