✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream #50418

h0rban · 2024-12-24T19:10:16Z

What

Adds the learning_stage_info to the adsets pull in source-facebook-marketing when it's available.

Issues:

#50851

How

AdSets schema is updated to include additional field.

Review guide

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/ad_sets.json

User Impact

additional available data

Can this PR be safely reverted and rolled back?

YES 💚
NO ❌

vercel · 2024-12-24T19:10:21Z

@h0rban is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2024-12-24T19:10:23Z

All committers have signed the CLA.

marcosmarxm · 2024-12-27T10:23:39Z

@airbytehq/dev-python can someone take a look in this contribution?

marcosmarxm · 2025-02-11T01:10:12Z

Hello 👋, I apologize if your contribution hasn't been reviewed or updated yet. I'm working to address the community contribution backlog. I created this GitHub project to help you understand when to expect a review. This week, my goal is to complete all contributions related to Marketplace and Manifest-only connectors. Next week, I will focus on API Certified Connectors, followed by DB Java Connector contributions. If you have any questions about your contribution, please feel free to send me a direct message in the Airbyte Community Slack (and include the link to your pull request).

vercel · 2025-03-06T19:26:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 11, 2025 1:19pm

marcosmarxm

The change looks good to me. I'm running tests. @h0rban let's wait for them, after they're green need final approval from connector team.

artem1205

small comment, please take a look,
otherwise LGTM!

artem1205 · 2025-03-07T11:52:53Z

airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_async_job.py

@@ -334,15 +334,16 @@ def test_get_result_retried(self, mocker, job, api):
        api.call().json.return_value = {"data": [{"some_data": 123}, {"some_data": 77}]}
        ads_insights = AdsInsights(api=api)
        ads_insights._set_data({"items": [{"some_data": 123}, {"some_data": 77}]})
-        with mocker.patch(
+        mocker.patch(


why do we need to remove context manager here?

@artem1205, i am seeing the following warning when running unit tests with the previous version.

airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_async_job.py::TestInsightAsyncJob::test_get_result_retried xxx/airbyte/airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_async_job.py:337: PytestMockWarning: Mocks returned by pytest-mock do not need to be used as context managers. The mocker fixture automatically undoes mocking at the end of a test. This warning can be ignored if it was triggered by mocking a context manager. https://pytest-mock.readthedocs.io/en/latest/remarks.html#usage-as-context-manager with mocker.patch(

TIL, thanks for the explanation @h0rban !

…ng-stage-info

artem1205

LGTM!

* ✨ Source Intercom: adding a mock server test (airbytehq#54715) * [Destination MS SQL V2] Correct Part Size, No buffered input stream (airbytehq#55252) * [source-hibob] Changed check stream from payrolls to profiles airbytehq#55674 (airbytehq#55675) * Add llms.txt to docs.airbyte.com (airbytehq#55261) * ✨ TikTok Marketing Source: Add `Pixels`, `PixelInstantPageEvents`, `PixelEventsStatistics` streams (airbytehq#55669) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * chore(ci): remove stale and unused workflows (airbytehq#55260) * ci: for community CI, rename 'early ci' to 'pre-release checks', skip duplicated tests in 'connector tests' (airbytehq#55241) * (feat: Salesloft) - Add emails_scoped_fields stream (airbytehq#55229) * 🐛 Source Outreach: remove stream_state interpolation (airbytehq#55180) Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * fix(source-stripe): disable progressive rollout (airbytehq#55682) Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com> * fix(source-instagram): Disable cache for InstagramMediaChildrenTransformation (airbytehq#55685) * [Destination MSSQL V2] Bulk Load Local Performance Test (airbytehq#55687) * [Destination-S3] File Xfer Local Performance Test (airbytehq#55220) * 🐛bug(source-hubspot): fix deals_archived and marketing_emails issues for CAT (airbytehq#54177) * ✨Source Quickbooks: Migrate to manifest-only (airbytehq#55263) * ✨ Source Zendesk Chat : Migrate to Manifest-only (airbytehq#47319) * ✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream (airbytehq#50418) Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> * Source Sendgrid: Update manifest for adapting changes with AsyncRetriever (airbytehq#55185) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * docs: fix broken markup in Python CDK Basic Concepts page (airbytehq#55699) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: natik@airbyte.io <natik@airbyte.io> * Source Zendesk Talk : Restore Unit Test (airbytehq#50956) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Natik Gadzhi <natik@respawn.io> * chore: 2.0.0 release (airbytehq#55684) * Adding EnrichedAirbyteValue and DeclaredField (airbytehq#55218) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * Add Airbyte Academy section (airbytehq#49964) * [source-faker] - Bump to stable 6.2.21 (airbytehq#55705) * fix: remove duplicate breaking changes from destination-mssql metadata (airbytehq#55718) * fix: restore definition ID (airbytehq#55720) * ✨ Source Freshdesk : Migrate to Manifest-only (airbytehq#54687) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * chore(source-s3): update base image to 4.0.0 and use caret dependencies (do not merge) (airbytehq#55202) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: natik@airbyte.io <natik@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Aldo Gonzalez <aldo.gonzalez@airbyte.io> * fix(Source-LinkedIn-Ads): Update outdated schema (airbytehq#55724) * Bump @babel/runtime-corejs3 from 7.23.6 to 7.26.10 in /docusaurus (airbytehq#55708) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🐛 Source S3: Up CDK to fix schema type issue (airbytehq#55694) * source-shipstation contribution from suhl79 (airbytehq#55738) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * destination-teradata: Upgrade JDBC driver (airbytehq#55183) Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * 🐛 Destination Databricks: Fix destination check test table collisions when multiple connections write to same schema. (airbytehq#55232) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * (source-sendgrid) - Configure max concurrent async job count (airbytehq#55744) * pass streams to debezium sources on cold start (airbytehq#55734) * Destination S3 Data Lake: exclude invalid fields from identifier fields (airbytehq#55700) * [source-mysql] pin to cdk 0.342 (airbytehq#55754) * docs: add enterprise connector documentation (airbytehq#55751) * Add UTM source (airbytehq#55733) * Matteogp/docs sap hana update 1 (airbytehq#55696) * Destination S3 Data Lake: Handle number in primary key (airbytehq#55755) * Fix reversed assertions in MySQL source tests (airbytehq#55756) * Update CDK to pass DestinationRecordRaw around (airbytehq#55737) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io> * fix(ci): remove empty notify-on-push workflow file (airbytehq#55757) * Update OTEL metrics, add new linting exceptions (airbytehq#55752) * 11526 second pass through iceberg documentation (airbytehq#55736) * [source-mysql] don't do sampling for source-mysql (airbytehq#55761) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * 🚨Source Fauna: Migrate to poetry (airbytehq#41051) --------- Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Maxime Carbonneau-Leclerc <3360483+maxi297@users.noreply.github.com> Co-authored-by: Johnny Schmidt <john.schmidt@airbyte.io> Co-authored-by: tautvydas-v <127105313+tautvydas-v@users.noreply.github.com> Co-authored-by: Ian Alton <ian.alton@airbyte.io> Co-authored-by: Tope Folorunso <66448986+topefolorunso@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io> Co-authored-by: Tyler B <104733644+tybernstein@users.noreply.github.com> Co-authored-by: kyleromines <163910384+kyleromines@users.noreply.github.com> Co-authored-by: Artem Inzhyyants <36314070+artem1205@users.noreply.github.com> Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com> Co-authored-by: Aldo Gonzalez <168454423+aldogonzalez8@users.noreply.github.com> Co-authored-by: Dhroov Makwana <pabloescoder@gmail.com> Co-authored-by: jake horban <j@portal.ai> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: btkcodedev <btk.codedev@gmail.com> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: natik@airbyte.io <natik@airbyte.io> Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io> Co-authored-by: Francis Genet <francis.genet@airbyte.io> Co-authored-by: Patrick Nilan <nilan.patrick@gmail.com> Co-authored-by: Aldo Gonzalez <aldo.gonzalez@airbyte.io> Co-authored-by: Alfredo Garcia <alfredo.garcia@hallmark.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: suhl79 <45366124+suhl79@users.noreply.github.com> Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com> Co-authored-by: Sena Heydari <sheyd@users.noreply.github.com> Co-authored-by: Matt Bayley <31358253+mwbayley@users.noreply.github.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io> Co-authored-by: Matteo Palarchio <20643714+matteogp@users.noreply.github.com> Co-authored-by: Wenqi Hu <wenqi.huu@gmail.com> Co-authored-by: Yue Li <61070669+theyueli@users.noreply.github.com>

add updates

1f6b968

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 24, 2024

h0rban had a problem deploying to community-ci December 24, 2024 19:10 — with GitHub Actions Error

h0rban temporarily deployed to community-ci-auto December 24, 2024 19:10 — with GitHub Actions Inactive

octavia-squidington-iii added community connectors/source/facebook-marketing labels Dec 24, 2024

h0rban added 3 commits December 24, 2024 11:12

update PR link in docs

85074a3

fix test warning

7cf17af

fix json formatting

89842b6

h0rban had a problem deploying to community-ci December 24, 2024 19:17 — with GitHub Actions Error

h0rban temporarily deployed to community-ci-auto December 24, 2024 19:17 — with GitHub Actions Inactive

h0rban marked this pull request as ready for review December 24, 2024 19:26

Merge branch 'master' into h0rban/add-learning-stage-info

dbd7104

h0rban had a problem deploying to community-ci December 24, 2024 19:28 — with GitHub Actions Error

h0rban temporarily deployed to community-ci-auto December 24, 2024 19:28 — with GitHub Actions Inactive

h0rban had a problem deploying to community-ci December 24, 2024 19:28 — with GitHub Actions Error

h0rban changed the title ~~✨ Source Facebook Marketing: Add learning_stage_info field to AdSets stream~~ ✨ Source Facebook Marketing: Add learning_stage_info field to AdSets stream Jan 2, 2025

Merge branch 'master' into h0rban/add-learning-stage-info

0bad382

h0rban had a problem deploying to community-ci January 2, 2025 19:22 — with GitHub Actions Error

h0rban temporarily deployed to community-ci-auto January 2, 2025 19:22 — with GitHub Actions Inactive

h0rban had a problem deploying to community-ci January 2, 2025 19:22 — with GitHub Actions Error

update issue link

3164646

h0rban had a problem deploying to community-ci January 2, 2025 19:28 — with GitHub Actions Error

h0rban had a problem deploying to community-ci-auto January 2, 2025 19:28 — with GitHub Actions Error

revert update issue link

f83243f

h0rban had a problem deploying to community-ci January 2, 2025 19:30 — with GitHub Actions Failure

h0rban temporarily deployed to community-ci-auto January 2, 2025 19:30 — with GitHub Actions Inactive

h0rban had a problem deploying to community-ci January 2, 2025 19:30 — with GitHub Actions Failure

Merge branch 'master' into h0rban/add-learning-stage-info

e75f341

marcosmarxm requested a review from a team as a code owner March 6, 2025 19:25

marcosmarxm had a problem deploying to community-ci-auto March 6, 2025 19:25 — with GitHub Actions Error

marcosmarxm had a problem deploying to community-ci March 6, 2025 19:25 — with GitHub Actions Error

poetry lock

11a03bf

marcosmarxm temporarily deployed to community-ci-auto March 6, 2025 19:26 — with GitHub Actions Inactive

marcosmarxm temporarily deployed to community-ci March 6, 2025 19:26 — with GitHub Actions Inactive

marcosmarxm approved these changes Mar 6, 2025

View reviewed changes

vercel bot deployed to Preview March 6, 2025 19:32 View deployment

artem1205 requested changes Mar 7, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/master' into h0rban/add-learni…

7ad48b9

…ng-stage-info

h0rban temporarily deployed to community-ci-auto March 10, 2025 17:20 — with GitHub Actions Inactive

h0rban temporarily deployed to community-ci March 10, 2025 17:20 — with GitHub Actions Inactive

artem1205 approved these changes Mar 10, 2025

View reviewed changes

vercel bot deployed to Preview March 11, 2025 13:19 View deployment

marcosmarxm merged commit a1801d7 into airbytehq:master Mar 11, 2025
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream #50418

✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream #50418

h0rban commented Dec 24, 2024 •

edited

Loading

vercel bot commented Dec 24, 2024

CLAassistant commented Dec 24, 2024 •

edited

Loading

marcosmarxm commented Dec 27, 2024

marcosmarxm commented Feb 11, 2025

vercel bot commented Mar 6, 2025 •

edited

Loading

marcosmarxm left a comment

artem1205 left a comment

artem1205 Mar 7, 2025

h0rban Mar 10, 2025 •

edited

Loading

artem1205 Mar 10, 2025

artem1205 left a comment

✨ Source Facebook Marketing: Add learning_stage_info field to AdSets stream #50418

✨ Source Facebook Marketing: Add learning_stage_info field to AdSets stream #50418

Conversation

h0rban commented Dec 24, 2024 • edited Loading

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

vercel bot commented Dec 24, 2024

CLAassistant commented Dec 24, 2024 • edited Loading

marcosmarxm commented Dec 27, 2024

marcosmarxm commented Feb 11, 2025

vercel bot commented Mar 6, 2025 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

artem1205 left a comment

Choose a reason for hiding this comment

artem1205 Mar 7, 2025

Choose a reason for hiding this comment

h0rban Mar 10, 2025 • edited Loading

Choose a reason for hiding this comment

artem1205 Mar 10, 2025

Choose a reason for hiding this comment

artem1205 left a comment

Choose a reason for hiding this comment

✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream #50418

✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream #50418

h0rban commented Dec 24, 2024 •

edited

Loading

CLAassistant commented Dec 24, 2024 •

edited

Loading

vercel bot commented Mar 6, 2025 •

edited

Loading

h0rban Mar 10, 2025 •

edited

Loading