-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Sendgrid: Update manifest for adapting changes with AsyncRetriever #55185
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/bump-version type="minor" changelog="Update manifest for adapting changes with AsyncRetriever"
|
This is ready |
Hey @btkcodedev we've prepared another small update for CDK > Decoders to be able to re-use them instead of the So, after this one is merged and released, we would need to update this PR as follows:
download_extractor:
type: ResponseToFileExtractor With the following: download_decoder:
type: GzipDecoder
decoder:
type: CsvDecoder Once the tests are green we should be good to merge it. |
Ok Thanks, Will do after airbytehq/airbyte-python-cdk#378 is merged!! 🙇 |
@btkcodedev The CDK update mentioned earlier was merged, please refer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Change:
- Replace
path
withurl_base
in thedownload_requester
.
After this modification, the code will be LGTM.
Thank you, @btkcodedev
@bazarnov, the bounces stream was fine before the upgrade, its failing now, any idea why? |
the stream looks untouched for me though! |
The
Looks like we should update them @DanyloGL Could you please help with this? Alternatively, we can skip checking this stream in the |
@btkcodedev I confirm that with the old CDK |
Added! This should work now |
Feel free to merge, once the CI is green again. |
* ✨ Source Intercom: adding a mock server test (airbytehq#54715) * [Destination MS SQL V2] Correct Part Size, No buffered input stream (airbytehq#55252) * [source-hibob] Changed check stream from payrolls to profiles airbytehq#55674 (airbytehq#55675) * Add llms.txt to docs.airbyte.com (airbytehq#55261) * ✨ TikTok Marketing Source: Add `Pixels`, `PixelInstantPageEvents`, `PixelEventsStatistics` streams (airbytehq#55669) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * chore(ci): remove stale and unused workflows (airbytehq#55260) * ci: for community CI, rename 'early ci' to 'pre-release checks', skip duplicated tests in 'connector tests' (airbytehq#55241) * (feat: Salesloft) - Add emails_scoped_fields stream (airbytehq#55229) * 🐛 Source Outreach: remove stream_state interpolation (airbytehq#55180) Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * fix(source-stripe): disable progressive rollout (airbytehq#55682) Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com> * fix(source-instagram): Disable cache for InstagramMediaChildrenTransformation (airbytehq#55685) * [Destination MSSQL V2] Bulk Load Local Performance Test (airbytehq#55687) * [Destination-S3] File Xfer Local Performance Test (airbytehq#55220) * 🐛bug(source-hubspot): fix deals_archived and marketing_emails issues for CAT (airbytehq#54177) * ✨Source Quickbooks: Migrate to manifest-only (airbytehq#55263) * ✨ Source Zendesk Chat : Migrate to Manifest-only (airbytehq#47319) * ✨ Source Facebook Marketing: Add `learning_stage_info` field to AdSets stream (airbytehq#50418) Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> * Source Sendgrid: Update manifest for adapting changes with AsyncRetriever (airbytehq#55185) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * docs: fix broken markup in Python CDK Basic Concepts page (airbytehq#55699) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: natik@airbyte.io <natik@airbyte.io> * Source Zendesk Talk : Restore Unit Test (airbytehq#50956) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Natik Gadzhi <natik@respawn.io> * chore: 2.0.0 release (airbytehq#55684) * Adding EnrichedAirbyteValue and DeclaredField (airbytehq#55218) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * Add Airbyte Academy section (airbytehq#49964) * [source-faker] - Bump to stable 6.2.21 (airbytehq#55705) * fix: remove duplicate breaking changes from destination-mssql metadata (airbytehq#55718) * fix: restore definition ID (airbytehq#55720) * ✨ Source Freshdesk : Migrate to Manifest-only (airbytehq#54687) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * chore(source-s3): update base image to 4.0.0 and use caret dependencies (do not merge) (airbytehq#55202) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: natik@airbyte.io <natik@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Aldo Gonzalez <aldo.gonzalez@airbyte.io> * fix(Source-LinkedIn-Ads): Update outdated schema (airbytehq#55724) * Bump @babel/runtime-corejs3 from 7.23.6 to 7.26.10 in /docusaurus (airbytehq#55708) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 🐛 Source S3: Up CDK to fix schema type issue (airbytehq#55694) * source-shipstation contribution from suhl79 (airbytehq#55738) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * destination-teradata: Upgrade JDBC driver (airbytehq#55183) Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * 🐛 Destination Databricks: Fix destination check test table collisions when multiple connections write to same schema. (airbytehq#55232) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * (source-sendgrid) - Configure max concurrent async job count (airbytehq#55744) * pass streams to debezium sources on cold start (airbytehq#55734) * Destination S3 Data Lake: exclude invalid fields from identifier fields (airbytehq#55700) * [source-mysql] pin to cdk 0.342 (airbytehq#55754) * docs: add enterprise connector documentation (airbytehq#55751) * Add UTM source (airbytehq#55733) * Matteogp/docs sap hana update 1 (airbytehq#55696) * Destination S3 Data Lake: Handle number in primary key (airbytehq#55755) * Fix reversed assertions in MySQL source tests (airbytehq#55756) * Update CDK to pass DestinationRecordRaw around (airbytehq#55737) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io> * fix(ci): remove empty notify-on-push workflow file (airbytehq#55757) * Update OTEL metrics, add new linting exceptions (airbytehq#55752) * 11526 second pass through iceberg documentation (airbytehq#55736) * [source-mysql] don't do sampling for source-mysql (airbytehq#55761) Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * 🚨Source Fauna: Migrate to poetry (airbytehq#41051) --------- Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Maxime Carbonneau-Leclerc <3360483+maxi297@users.noreply.github.com> Co-authored-by: Johnny Schmidt <john.schmidt@airbyte.io> Co-authored-by: tautvydas-v <127105313+tautvydas-v@users.noreply.github.com> Co-authored-by: Ian Alton <ian.alton@airbyte.io> Co-authored-by: Tope Folorunso <66448986+topefolorunso@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io> Co-authored-by: Tyler B <104733644+tybernstein@users.noreply.github.com> Co-authored-by: kyleromines <163910384+kyleromines@users.noreply.github.com> Co-authored-by: Artem Inzhyyants <36314070+artem1205@users.noreply.github.com> Co-authored-by: Anatolii Yatsuk <35109939+tolik0@users.noreply.github.com> Co-authored-by: Aldo Gonzalez <168454423+aldogonzalez8@users.noreply.github.com> Co-authored-by: Dhroov Makwana <pabloescoder@gmail.com> Co-authored-by: jake horban <j@portal.ai> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: btkcodedev <btk.codedev@gmail.com> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: natik@airbyte.io <natik@airbyte.io> Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io> Co-authored-by: Francis Genet <francis.genet@airbyte.io> Co-authored-by: Patrick Nilan <nilan.patrick@gmail.com> Co-authored-by: Aldo Gonzalez <aldo.gonzalez@airbyte.io> Co-authored-by: Alfredo Garcia <alfredo.garcia@hallmark.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: suhl79 <45366124+suhl79@users.noreply.github.com> Co-authored-by: Satish Chinthanippu <satish.chinthanippu@teradata.com> Co-authored-by: Sena Heydari <sheyd@users.noreply.github.com> Co-authored-by: Matt Bayley <31358253+mwbayley@users.noreply.github.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io> Co-authored-by: Matteo Palarchio <20643714+matteogp@users.noreply.github.com> Co-authored-by: Wenqi Hu <wenqi.huu@gmail.com> Co-authored-by: Yue Li <61070669+theyueli@users.noreply.github.com>
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11787
How
Definition of Done:
The source-sendgrid works with the updated manifest.yaml considering the changes made here
In specific:
upgrade the CDK version to at least 6.36.3
rename the urls_extractor to download_target_extractor, here
move off the stream_slice interpolation context to use the {{creation_response['id']}}, here
move off the stream_slice interpolation context to use the {{download_target}}, here
make sure the CAT passes, as before
make sure the Regression Tests pass, as before
no source behaviour changes are expected
Follow the airbytehq/airbyte-python-cdk#368 (User Impact section) for more information about the changes.