Messages in this thread |  | Date | Tue, 27 Sep 2022 17:23:28 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v10 11/27] rust: add `bindings` crate |
| |
On Tue, Sep 27, 2022 at 03:14:42PM +0200, Miguel Ojeda wrote: > This crate contains the bindings to the C side of the kernel. > > Calling C (in general, FFI) is assumed to be unsafe in Rust > and, in many cases, this is accurate. For instance, virtually > all C functions that take a pointer are unsafe since, typically, > it will be dereferenced at some point (and in most cases there > is no way for the callee to check its validity beforehand). > > Since one of the goals of using Rust in the kernel is precisely > to avoid unsafe code in "leaf" kernel modules (e.g. drivers), > these bindings should not be used directly by them. > > Instead, these bindings need to be wrapped into safe abstractions. > These abstractions provide a safe API that kernel modules can use. > In this way, unsafe code in kernel modules is minimized. > > Co-developed-by: Alex Gaynor <alex.gaynor@gmail.com> > Signed-off-by: Alex Gaynor <alex.gaynor@gmail.com> > Co-developed-by: Finn Behrens <me@kloenk.de> > Signed-off-by: Finn Behrens <me@kloenk.de> > Co-developed-by: Wedson Almeida Filho <wedsonaf@google.com> > Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com> > Co-developed-by: Sven Van Asbroeck <thesven73@gmail.com> > Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com> > Co-developed-by: Gary Guo <gary@garyguo.net> > Signed-off-by: Gary Guo <gary@garyguo.net> > Co-developed-by: Maciej Falkowski <m.falkowski@samsung.com> > Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com> > Co-developed-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > Co-developed-by: Björn Roy Baron <bjorn3_gh@protonmail.com> > Signed-off-by: Björn Roy Baron <bjorn3_gh@protonmail.com> > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > rust/bindings/bindings_helper.h | 13 ++++++++ > rust/bindings/lib.rs | 53 +++++++++++++++++++++++++++++++++ > 2 files changed, 66 insertions(+) > create mode 100644 rust/bindings/bindings_helper.h > create mode 100644 rust/bindings/lib.rs
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|  |