Date | Tue, 27 Sep 2022 16:05:41 +0200 | From | Geert Stappers <> | Subject | Re: [PATCH v10 01/27] kallsyms: use `ARRAY_SIZE` instead of hardcoded size |
| |
On Tue, Sep 27, 2022 at 03:14:32PM +0200, Miguel Ojeda wrote: > From: Boqun Feng <boqun.feng@gmail.com> > > This removes one place where the `500` constant is hardcoded. > > Reviewed-by: Kees Cook <keescook@chromium.org> > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > Co-developed-by: Miguel Ojeda <ojeda@kernel.org> > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > scripts/kallsyms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c > index f18e6dfc68c5..8551513f9311 100644 > --- a/scripts/kallsyms.c > +++ b/scripts/kallsyms.c > @@ -206,7 +206,7 @@ static struct sym_entry *read_symbol(FILE *in) > > rc = fscanf(in, "%llx %c %499s\n", &addr, &type, name); > if (rc != 3) { > - if (rc != EOF && fgets(name, 500, in) == NULL) > + if (rc != EOF && fgets(name, ARRAY_SIZE(name), in) == NULL) > fprintf(stderr, "Read error or end of file.\n"); > return NULL; > } > -- > 2.37.3 >
Reviewed-by: Geert Stappers <stappers@stappers.nl>
Regards Geert Stappers Hopes to see the kallsyms patches getting accepted, that they don't show up in v11 of the Rust patch serie. -- Silence is hard to parse
|