Date | Tue, 27 Sep 2022 17:03:17 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v10 15/27] scripts: checkpatch: diagnose uses of `%pA` in the C side as errors |
| |
On Tue, Sep 27, 2022 at 03:14:46PM +0200, Miguel Ojeda wrote: > The `%pA` format specifier is only intended to be used from Rust. > > `checkpatch.pl` already gives a warning for invalid specificers: > > WARNING: Invalid vsprintf pointer extension '%pA' > > This makes it an error and introduces an explanatory message: > > ERROR: Invalid vsprintf pointer extension '%pA' - '%pA' is only intended to be used from Rust code > > Suggested-by: Kees Cook <keescook@chromium.org> > Co-developed-by: Alex Gaynor <alex.gaynor@gmail.com> > Signed-off-by: Alex Gaynor <alex.gaynor@gmail.com> > Co-developed-by: Wedson Almeida Filho <wedsonaf@google.com> > Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com> > Co-developed-by: Joe Perches <joe@perches.com> > Signed-off-by: Joe Perches <joe@perches.com> > Signed-off-by: Miguel Ojeda <ojeda@kernel.org> > --- > scripts/checkpatch.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|