-
Notifications
You must be signed in to change notification settings - Fork 122
Update docs, tests, summaries for stable extensions #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs, tests, summaries for stable extensions #372
Conversation
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
==========================================
+ Coverage 89.43% 89.69% +0.26%
==========================================
Files 39 39
Lines 5063 5154 +91
==========================================
+ Hits 4528 4623 +95
+ Misses 535 531 -4
Continue to review full report at Codecov.
|
Yeah, maybe "v" is better as "s" on citation. We had the case where we had a regexp for the year number in the citation summary, which would be a use case. But I agree that in general, a list of values is probably the better option. Opened PR stac-utils/stac-fields#11 for it. |
* Use default behavior (list of values) instead of schema Origin: stac-utils/pystac#372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, couple of suggestions but overall +1
...for consistency with EO extension after stac-utils#377
Related Issue(s): #
Description:
view
,projection
, andscientific
extensionsdoi
an optional argument forScientificExtension
andPublication
to match specview
,projection
, andscientific
extensionsstac-fields
indicates that JSON Schema format should be used forsci:citation
summaries, but using a simple list seemed more appropriate, so that's how I implemented it for now. @m-mohr @matthewhanson Maybe you have more insight around the rationale for using the JSON Schema summaries for that field?PR Checklist:
scripts/format
)scripts/test
)