Skip to content

eo.py: Add more typing info for module level strings #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

schwehr
Copy link
Collaborator

@schwehr schwehr commented May 31, 2021

Description:

Trivial addition of typing to module level strings

PR Checklist:

  • Code is formatted (run scripts/format)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #377 (ec5d222) into main (e90f809) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          37       37           
  Lines        4677     4677           
=======================================
  Hits         4199     4199           
  Misses        478      478           
Impacted Files Coverage Δ
pystac/extensions/eo.py 97.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90f809...ec5d222. Read the comment docs.

@schwehr schwehr requested a review from duckontheweb May 31, 2021 15:51
@lossyrob lossyrob merged commit a6ac489 into stac-utils:main Jun 1, 2021
duckontheweb added a commit to duckontheweb/pystac that referenced this pull request Jun 2, 2021
...for consistency with EO extension after stac-utils#377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants