Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ferret tests #247

Closed
wants to merge 45 commits into from
Closed

ferret tests #247

wants to merge 45 commits into from

Conversation

themighty1
Copy link
Collaborator

This PR adds a missing assert on a fn input and improves the tests.

sinui0 and others added 30 commits March 3, 2025 10:44
* feat: lazy ot

* remove ctx feature

* improve cot test

* improve tests
* refactor: spawn threads in mt executor

* chore: replace alloc and preprocess trait
* feat: lazy ole and share conversion

* zero check

* argument doc
* fix(mpz-share-conversion): add missing module comment and fix dependencies

* Remove feature flag from test module

* Make test module not public.
* adjust block lsb and ops

* feat: garble vm

* fix test

* remove redundant test
* fix(garble): do not hang when output is used as input

* fix(garble): fix hanging in preprocessing

* fix: adapt `is_committed` to consider complete outputs
* feat: quicksilver

* fix bench

* error handling

* remove asserts

* rename variables in fold

Co-authored-by: Xiang Xie <xiexiangiscas@gmail.com>
* refactor: concrete Context type

* add Execute to Vm trait
* feat: DecodeExt

* refactor to OTP instead of decoding

* remove sized bound

* fix input count
* feat: shared RCOT

* remove barrier

* set alloc to 0 afterwards

* Revert "remove barrier"

This reverts commit b004c0b.

* Revert "set alloc to 0 afterwards"

This reverts commit d3d79f4.

* typo
sinui0 and others added 15 commits March 3, 2025 10:48
* feat: ferret

* enforce shape of regular lpn params

* fix naming and comments

* typo

* move up vector truncate
* chore: fix lints

* fix: add lto release profile to workspace
* feat: add encoding trait for zk vm

* doc: add trait comment

* fix: remove trait and use methods instead

* fix: rename errors

* fix: return slice and implement for `Binary` only

* fix: improve error msg for verifier
…241)

* Add missing adjustment bits.

* Move hasher to mpz-zk.
* chore: please clippy

* add feedback

* add new feedback

---------

Co-authored-by: sinu.eth <65924192+sinui0@users.noreply.github.com>
@themighty1 themighty1 requested a review from th4s March 4, 2025 12:26
@th4s
Copy link
Member

th4s commented Mar 6, 2025

You probably want to rebase this and merge into dev instead of alpha.1.

Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo th4s comment

@themighty1 themighty1 changed the base branch from alpha.1 to dev March 10, 2025 08:11
This was referenced Mar 10, 2025
@themighty1
Copy link
Collaborator Author

closing in favor of #256

@themighty1 themighty1 closed this Mar 10, 2025
@sinui0 sinui0 deleted the ferret_tests branch March 10, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants