-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ferret tests #247
Closed
Closed
ferret tests #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: lazy ot * remove ctx feature * improve cot test * improve tests
* refactor: spawn threads in mt executor * chore: replace alloc and preprocess trait
* feat: lazy ole and share conversion * zero check * argument doc
* fix(mpz-share-conversion): add missing module comment and fix dependencies * Remove feature flag from test module * Make test module not public.
* adjust block lsb and ops * feat: garble vm * fix test * remove redundant test
* fix(garble): do not hang when output is used as input * fix(garble): fix hanging in preprocessing * fix: adapt `is_committed` to consider complete outputs
* feat: quicksilver * fix bench * error handling * remove asserts * rename variables in fold Co-authored-by: Xiang Xie <xiexiangiscas@gmail.com>
* refactor: concrete Context type * add Execute to Vm trait
* feat: DecodeExt * refactor to OTP instead of decoding * remove sized bound * fix input count
* feat: ferret * enforce shape of regular lpn params * fix naming and comments * typo * move up vector truncate
* chore: fix lints * fix: add lto release profile to workspace
* feat: add encoding trait for zk vm * doc: add trait comment * fix: remove trait and use methods instead * fix: rename errors * fix: return slice and implement for `Binary` only * fix: improve error msg for verifier
…241) * Add missing adjustment bits. * Move hasher to mpz-zk.
* chore: please clippy * add feedback * add new feedback --------- Co-authored-by: sinu.eth <65924192+sinui0@users.noreply.github.com>
th4s
approved these changes
Mar 6, 2025
You probably want to rebase this and merge into |
sinui0
approved these changes
Mar 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo th4s comment
closing in favor of #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing assert on a fn input and improves the tests.