Fix File.flush return value for case of zero bytes to flush. #2704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
File.flush
returnsfalse
when the number of bytes pending to write is zero, even though the docstring says that:This situation should fall under the
true
condition - all pending data was successfully written - it's just that the number of bytes was zero. It definitely doesn't fall under thefalse
condition because it has nothing to do with write permissions.This PR fixes that bug and adds a test.