Fix missing fetch #113
Merged
Fix missing fetch #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oowekyala
commented
May 9, 2022
| Cmd.execute_successfully(clone_cmd) | ||
| end | ||
|
|
||
| Dir.chdir(path) do | ||
| execute_reset_cmd(project.type, project.tag) | ||
| # this should work with tags, branch names and (full-length) hashes | ||
| Cmd.execute_successfully("git fetch --depth 1 origin #{tag}") |
There was a problem hiding this comment.
note: i haven't actually checked whether this works for tags. the proper syntax is maybe tags/tagname. will check tomorrow
There was a problem hiding this comment.
There was a problem hiding this comment.
I'll look at this - I like the idea to use a fetch here. This will make it easier to reuse the clones, even if upstream changes.
Problem was, that git fetch won't create a local ref by default. Creating now a branch from FETCH_HEAD which works with commits and tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #106
Ref problems in pmd/pmd#3960