git clone/checkout fails when using commit sha1 as tag

[adangel]

Currently we need to fork Schedul-o-matic-9000 and fflib-apex-common in order to create a tag, that we can use in project-list.xml:

  <project>
    <name>Schedul-o-matic-9000</name>
    <type>git</type>
    <connection>https://github.com/pmd/Schedul-o-matic-9000</connection>
    <!-- 
    <connection>https://github.com/SalesforceLabs/Schedul-o-matic-9000</connection>
    Note: using forked repo from pmd, as original repo doesn't have any useful tags/branches
    -->
    <tag>pmd-regression-test</tag>
  </project>

It would be nice to allow to specify directly a sha1 for the commit, e.g.

  <project>
    <name>Schedul-o-matic-9000</name>
    <type>git</type>
    <connection>https://github.com/SalesforceLabs/Schedul-o-matic-9000</connection>
    <tag>6b1229ba43b38931fbbab5924bc9b9611d19a786</tag>
  </project>

Using the tag-tag would avoid to change the schema for this file.

[adangel]

Hm... this does already work. At least in the integration test.

[adangel]

$ git status
HEAD detached at 6b1229b
nothing to commit, working tree clean

All pmd-regression-tester does, is executing: git checkout 6b1229ba43b38931fbbab5924bc9b9611d19a786 && git reset --hard 6b1229ba43b38931fbbab5924bc9b9611d19a786:

pmd-regression-tester/lib/pmdtester/builders/project_builder.rb

Line 100 in 0b3d39f

reset_cmd = "git checkout #{tag}; git reset --hard #{tag}"

And that works fine. Git checks out in detached mode.

[adangel]

Ok, so it works for https://github.com/SalesforceLabs/Schedul-o-matic-9000 because "6b1229ba43b38931fbbab5924bc9b9611d19a786" is the latest commit referenced by HEAD: https://github.com/SalesforceLabs/Schedul-o-matic-9000/commits/master

As soon as a new commit is added, it'll stop working.

For the other repo https://github.com/apex-enterprise-patterns/fflib-apex-common we use the commit "7e0891efb86d23de62811af56d87d0959082a322", which is not the HEAD, and hence it fails:

git clone --no-single-branch --depth 1 https://github.com/apex-enterprise-patterns/fflib-apex-common test-fflib-apex-common
cd test-fflib-apex-common && git checkout 7e0891efb86d23de62811af56d87d0959082a322 && git reset --hard 7e0891efb86d23de62811af56d87d0959082a322 && cd ..
fatal: reference is not a tree: 7e0891efb86d23de62811af56d87d0959082a322