Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back "Outdated" label #1417

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add back "Outdated" label #1417

merged 2 commits into from
Oct 28, 2019

Conversation

JacksonKearl
Copy link
Contributor

@JacksonKearl JacksonKearl commented Oct 26, 2019 •
edited
Loading

Fixes #1407.

Removed some CSS that to me made it look worse, might want to find some new CSS for this?

@JacksonKearl JacksonKearl self-assigned this Oct 26, 2019
@JacksonKearl JacksonKearl mentioned this pull request Oct 26, 2019
Closed
RMacfarlane
RMacfarlane reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to consolidate the css for the pending and outdated labels:
Screen Shot 2019-10-28 at 10 33 48 AM

@JacksonKearl
Copy link
Contributor Author

image
The new look

@RMacfarlane RMacfarlane merged commit f39d815 into master Oct 28, 2019
@RMacfarlane RMacfarlane deleted the jackson/outdated-label branch October 28, 2019 23:48
@JacksonKearl JacksonKearl mentioned this pull request Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMacfarlane RMacfarlane RMacfarlane approved these changes

Assignees

@JacksonKearl JacksonKearl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display of outdated comments on description page
2 participants
@JacksonKearl @RMacfarlane