Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of outdated comments on description page #1407

Closed
RMacfarlane opened this issue Oct 24, 2019 · 2 comments · Fixed by #1417
Closed

Display of outdated comments on description page #1407

RMacfarlane opened this issue Oct 24, 2019 · 2 comments · Fixed by #1417
Assignees

Comments

@RMacfarlane
Copy link
Contributor

  • Extension version: 0.12.0

Steps to Reproduce:

  1. Open the description page on a PR that has outdated comments

I believe there was previously a box rendered near the top of the comment saying "Outdated". At a minimum, we should bring that back. Even better would be having a collapsed view of these by default as they are on github.com and a way of toggling their visibility

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Oct 26, 2019

having a collapsed view of these by default as they are on github.com and a way of toggling their visibility

I actually don't see them collapsed by default on GitHub... on GitHub there is a separate "Mark Resolved" button, and "Resolved" threads are collapsed by default. A thread can be resolved even if it is not outdated, so I think this is an orthogonal feature.

@JacksonKearl
Copy link
Contributor

Looks like resolving convos is already covered in #339. #1417 adds the "Outdated" label, I'll look into "Resolved" next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants