-
Notifications
You must be signed in to change notification settings - Fork 138
model: Rename directory property to location #662
Comments
@pdxjohnny I'd like to work on this issue |
@sudharsana-kjl Sweet! I forgot to say sorry, we need to do #655 first |
This could be done now, but that issue and this issue will probably change a lot of the same code, so it's probably best if we do that issue first because it needs to get done before the next release |
And if we do both at the same time then we'll end up with a nasty merge |
@pdxjohnny I'll work on #655 first and then come back to this! |
@pdxjohnny |
Hi, just wondering if this is still open for gsoc 2021? Thank you |
|
Related discussion from Weekly Sync 2021-07-13 |
Pulled __aenter__/__aexit__() out of context classes put in parent classes. Added a tutorial for archive support. Spacy model_name_or_path was changed to model_name. Fixes: #662 Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
high_level.py becomes high_level/{ml,dataflow,source}.py Fixes: intel#1170 Related: intel#662
Pulled __aenter__/__aexit__() out of context classes put in parent classes. Added a tutorial for archive support. Spacy model_name_or_path was changed to model_name. Fixes: intel#662 Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Pulled __aenter__/__aexit__() out of context classes put in parent classes. Added a tutorial for archive support. Spacy model_name_or_path was changed to model_name. Fixes: #662 Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
Hi ! Decided to work on this issue so anyone for a headstart ? |
Hey @ren276 !! |
Support Archive Storage for Models
The goal of this project is the modify Models and DataFlows to support saving
and loading from archives (such as
.zip
and.tar
for example).Currently all DFFML models have a
directory
property, which is where theystore the contents of the model's state. It does not currently hold a copy of
the model's config.
We'll want to modify the Model's context entry and exit code to have it
pack/unpack it's config and its saved state directory from/into the archive at
location
.Skills
Difficulty
Beginner/Intermediate
Related Readings
Getting Started
is a rough guide meant to give you some activities that will help you better
understand what needs to be done so you can write a more complete proposal.
directory
property tolocation
for all models.__aenter__()
ofdffml.model.model.Model
, iflocation
has anextension, such as zip or tar, extract it to a temporary directory.
get_directory()
, which returns the location of thetemporary directory property on the
Model
class.__aexit__()
, pack the model state directory into thelocation
, alongwith it's config.
be changed (
dffml/model
andmodel/
)Potential Mentors
Tracking and Discussion
This project is related to the following issues. Please discuss and ask
questions in the issue comments. Please also ping mentors on
Gitter when you post on the following
issues so that they are sure to see that you've commented.
The text was updated successfully, but these errors were encountered: