Skip to content
This repository was archived by the owner on Aug 25, 2024. It is now read-only.

high_level: Move code into a directory and splitting out into files. #1170

Closed
programmer290399 opened this issue Jul 18, 2021 · 2 comments · Fixed by #1172
Closed

high_level: Move code into a directory and splitting out into files. #1170

programmer290399 opened this issue Jul 18, 2021 · 2 comments · Fixed by #1172
Labels
enhancement New feature or request

Comments

@programmer290399
Copy link
Contributor

programmer290399 commented Jul 18, 2021

Pain Point

It is currently not possible to import some high-level functionalities in other core parts of dffml like model.py due to formation of circular import chains.

Which blocks implementation of archive support for #662

References

Proposed Solution

Split the high_level code into a directory and splitting out into files such as high_level/dataflow.py (similar to cli)

A proposed split tree is given below :

high_level
├── __init__.py
├── high_level.py
│   └── _records_to_sources
├── dataflow.py
│   └── run
├── source.py
│   ├── save
│   └── load
└── ml.py
    ├── train
    ├── accuracy
    └── predict

Tree structure made with tree.nathanfriend.io

@programmer290399 programmer290399 added the enhancement New feature or request label Jul 18, 2021
@programmer290399
Copy link
Contributor Author

ping @pdxjohnny

@johnandersen777
Copy link

Let's get that helper function out of there. Otherwise looks great!

(echo -e '"""\nHelper functions for dealing with internal data types\n"""\n\n'&& grep -A 39 def\ _records -- dffml/high_level.py | sed -e 's/def _r/def r/') | tee dffml/util/internal.py

johnandersen777 pushed a commit that referenced this issue Jul 24, 2021
high_level.py becomes high_level/{ml,dataflow,source}.py

Fixes: #1170
Related: #662
johnandersen777 pushed a commit to johnandersen777/dffml that referenced this issue Mar 11, 2022
high_level.py becomes high_level/{ml,dataflow,source}.py

Fixes: intel#1170
Related: intel#662
johnandersen777 pushed a commit that referenced this issue Mar 12, 2022
high_level.py becomes high_level/{ml,dataflow,source}.py

Fixes: #1170
Related: #662
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants