Skip to content

Regression version comparison incorrectly identified issue as regressed, when version was older than resolved-in version #74448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jboulter11 opened this issue Jul 17, 2024 · 9 comments · Fixed by #82001
Closed

Regression version comparison incorrectly identified issue as regressed, when version was older than resolved-in version #74448

jboulter11 opened this issue Jul 17, 2024 · 9 comments · Fixed by #82001
Assignees
@scttcper
Labels
Product Area: Issues Sync: Jira Apply to auto-create a Jira shadow ticket

Comments

@jboulter11
Copy link

jboulter11 commented Jul 17, 2024 •
edited by sync-by-unito bot
Loading

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

See:
https://dropbox.sentry.io/issues/5597803787/activity/?project=4505546600087552

I do not know why this happened.

Expected Result

Sentry should have compared the version numbers 388.0.6 vs 388.0.8 and concluded there was no regression.

Actual Result

Sentry compared 388.0.6 and 388.0.8 and determined 388.0.6 to be equal to or greater than 388.0.8, which is incorrect.

Product Area

Issues

Link

https://dropbox.sentry.io/issues/5597803787/activity/?project=4505546600087552

DSN

No response

Version

No response

┆Issue is synchronized with this Jira Improvement by Unito
@getsantry
Copy link
Contributor

getsantry bot commented Jul 17, 2024

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jul 17, 2024
@irodrigues-git irodrigues-git added the Sync: Jira Apply to auto-create a Jira shadow ticket label Jul 18, 2024
@armenzg
Copy link
Member

armenzg commented Jul 18, 2024

Hey @jboulter11 👋
Thanks for reporting. I will have a look.

armenzg added a commit that referenced this issue Jul 18, 2024
@armenzg
test(event_manager): Test case
b33c2b1 
This attempts to reproduce the test case for issue #74448.
@armenzg armenzg mentioned this issue Jul 18, 2024
Closed
@getsentry getsentry deleted a comment from armenzg Jul 18, 2024
@armenzg
Copy link
Member

armenzg commented Jul 19, 2024

For anyone who ends up picking this up, this PR tries to reproduce this issue:
https://github.com/getsentry/sentry/pull/74526/files

@jboulter11
Copy link
Author

This happened again but this time with versions using release date instead of semver: https://dropbox.sentry.io/issues/5918496859/activity/?project=4505546831036416

44d3cb5 is older than 28a9559 but it is being treated as newer and reopening the ticket here.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 29, 2024
@lobsterkatie
Copy link
Member

Huh - you're right, that does seem quite backwards.

Image
Image
Image

When your colleague marked it as resolved shortly before it got marked as having regressed, do you happen to know which resolve option he used? (It shouldn't matter - they should all work - but I'm trying to narrow down my search for the problem. The code in question is relatively straightforward, and nothing is jumping out at me.)
Image

@jboulter11
Copy link
Author

I unfortunately do not know and due to yesterday's layoffs, I cannot ask them. I'd guess they either picked next version or they picked a specific commit/current release. I can't be sure, unfortunately.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 31, 2024
@lobsterkatie
Copy link
Member

Oof. Bad timing, sorry. 😓

Okay, I'll keep investigating, thanks.

@armenzg
Copy link
Member

armenzg commented Nov 14, 2024

There's a chance that this bug may also be fixed by #80737

@armenzg armenzg mentioned this issue Nov 14, 2024
Merged
armenzg added a commit that referenced this issue Nov 15, 2024
@armenzg
fix(releases): For semver releases, get latest release as the resolvi…
a087bb8 
…ng one (#80737)

Select the latest semver release for the project rather than the latest
seen for the group.

This is a follow-up to #80655.
This fixes the customer issue
#69937 (and possibly these:
#74448 and #80194).
@armenzg
Copy link
Member

armenzg commented Nov 15, 2024

I just noticed you also reported sha-based releases. I will look at it this afternoon.

This happened again but this time with versions using release date instead of semver: https://dropbox.sentry.io/issues/5918496859/activity/?project=4505546831036416

44d3cb5 is older than 28a9559 but it is being treated as newer and reopening the ticket here.

@JParisFerrer JParisFerrer mentioned this issue Nov 18, 2024
Closed
@armenzg armenzg removed their assignment Nov 18, 2024
scttcper added a commit that referenced this issue Dec 12, 2024
@scttcper
feat(integrations): Ignore duplicate group resolution
c7198fe 
On integrations that sync status like jira, it can override the user's in app resolution.

Workflow:
- User marks an issue as resolved in release A
- Group activity is recorded saying user resolved in release
- We sync status to jira resolving the linked issue
- Jira webhooks us back attempting to sync status (resolve in next release)
- We update the group resolution to resolve in next release but we don't create an activity. When the issue regresses it is confusing since the GroupResolution and Group Activities don't make sense.

This change would ignore the jira webhook if the group is already resolved and was resolved in the last 3 minutes.

fixes #74448
@scttcper scttcper mentioned this issue Dec 12, 2024
Merged
@scttcper scttcper self-assigned this Dec 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scttcper scttcper

Labels
Product Area: Issues Sync: Jira Apply to auto-create a Jira shadow ticket
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(integrations): Ignore duplicate group resolution getsentry/sentry
5 participants
@armenzg @scttcper @jboulter11 @lobsterkatie @irodrigues-git