Skip to content

test(event_manager): Test case #74526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/event_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -2109,8 +2109,8 @@ def _handle_regression(group: Group, event: BaseEvent, release: Release | None)

# we only mark it as a regression if the event's release is newer than
# the release which we originally marked this as resolved
elif GroupResolution.has_resolution(group, release):
return None
# elif GroupResolution.has_resolution(group, release):
# return None
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm forcing the issue to happen.

In my test case, we end up reaching this comparison:

elif res_type == cls.Type.in_release:
# If release id provided is the same as resolved release id then return False
# regardless of whether it is a semver project or not
if res_release == release.id:
return False
if follows_semver:
try:
# A resolution only exists if the resolved release is greater (in semver
# terms) than the provided release
res_release_raw = parse_release(
res_release_version, json_loads=orjson.loads
).get("version_raw")
release_raw = parse_release(release.version, json_loads=orjson.loads).get(
"version_raw"
)
return compare_version_relay(res_release_raw, release_raw) == 1


elif has_pending_commit_resolution(group):
return None
Expand Down
78 changes: 78 additions & 0 deletions tests/sentry/event_manager/test_event_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,84 @@ def test_resolved_in_release_regression_activity_follows_semver(
assert regressed_activity.data["follows_semver"] is True
assert regressed_activity.data["resolved_in_version"] == "foo@1.0.0"

def resolve_in_release(self, group: Group, release: Release) -> Activity:
group.update(status=GroupStatus.RESOLVED, substatus=None)
resolution = GroupResolution.objects.create(
release=release,
group=group,
type=GroupResolution.Type.in_release,
)
return Activity.objects.create(
group=group,
project=group.project,
type=ActivityType.SET_RESOLVED_IN_RELEASE.value,
ident=resolution.id,
data={"version": release.version},
)

@mock.patch("sentry.event_manager.plugin_is_regression")
def test_does_not_resolve_for_semver(self, plugin_is_regression: mock.MagicMock) -> None:
plugin_is_regression.return_value = True

def _date(minutes: int) -> datetime:
return timezone.now() - timedelta(minutes=minutes)

first_release_version = "com.foo.FooTest@387.0+387.0.18"
first_release = self.create_release(version=first_release_version, date_added=_date(90))

manager = EventManager(
make_event(
event_id="a" * 32,
checksum="a" * 32,
# 10 minutes after release creation
timestamp=time() - 80 * 60,
release=first_release.version,
)
)
event = manager.save(self.project.id)
assert event.group is not None
group = event.group

patch_version6 = "com.foo.FooTest@388.0+388.0.6"
release_06 = self.create_release(version=patch_version6, date_added=_date(70))

patch_version8 = "com.foo.Foo@388.0+388.0.8"
release_08 = self.create_release(version=patch_version8, date_added=_date(65))

self.create_release(version="com.foo.Foo@388.0+388.0.13", date_added=_date(60))

# Marking as resolved in the second latest release
self.resolve_in_release(group, release_08)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the releases above already exist once the developer calls "resolve in release X".


# Creates event for an older release
manager = EventManager(
make_event(
event_id="c" * 32,
checksum="a" * 32,
timestamp=time(),
# Notice that the event is for an older release
release=release_06.version,
)
)
event = manager.save(self.project.id)
assert event.group is not None
group = event.group

# # XXX: The GH issue shows that it should have unresolved
# assert group.status == GroupStatus.RESOLVED
# # XXX: The GH issue shows that it should have a regression
# with pytest.raises(Activity.DoesNotExist):
# Activity.objects.get(group=group, type=ActivityType.SET_REGRESSION.value)

# When GroupResolution.has_resolution(group, release) does not execute we reproduce the issue
assert group.status == GroupStatus.UNRESOLVED
regressed_activity = Activity.objects.get(
group=group, type=ActivityType.SET_REGRESSION.value
)
assert regressed_activity.data["version"] == release_06.version
assert regressed_activity.data["follows_semver"] is True
assert regressed_activity.data["resolved_in_version"] == release_08.version

def test_has_pending_commit_resolution(self) -> None:
project_id = self.project.id
event = self.make_release_event("1.0", project_id)
Expand Down
Loading