feat: Add support for BackendTLSPolicy to target ServiceImport #5451
+394
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Teju Nareddy <tejunareddy@gmail.com>
nareddyt
commented
Mar 10, 2025
| settings: | ||
| - name: httproute/envoy-gateway/httproute-btls/rule/0/backend/0 | ||
| protocol: HTTP | ||
| tls: |
There was a problem hiding this comment.
This is the key section we are looking for. Previous test run was missing tls without the code changes in this PR.
nareddyt
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5451 +/- ##
==========================================
+ Coverage 65.30% 65.33% +0.02%
==========================================
Files 213 213
Lines 33915 33915
==========================================
+ Hits 22147 22157 +10
+ Misses 10438 10432 -6
+ Partials 1330 1326 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
reviewed
Mar 12, 2025
Comment on lines
+1409
to
+1414
| // TODO(tnareddy): Should these protocols be supported for ServiceImport? | ||
| // Follow-up in separate issue and PR. | ||
| // | ||
| // if servicePort.AppProtocol != nil { | ||
| // protocol = serviceAppProtocolToIRAppProtocol(*servicePort.AppProtocol) | ||
| // } |
zirain
approved these changes
Mar 12, 2025
|
all tests are failing, is this a flake or a real issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BackendTLSPolicy only supports Service and Backend targetRefs, it doesn't support ServiceImport.
Fix
This PR adds support for that case.
Testing Done
Added a new translator test case that verifies
tlssettings appear in the xDS IR for ServiceImports.Additional Info
Fixes #5376
Release Notes: Yes