Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackendTLSPolicy does not support ServiceImport backends #5376

Open
muwaqar opened this issue Feb 28, 2025 · 1 comment · May be fixed by #5451
Open

BackendTLSPolicy does not support ServiceImport backends #5376

muwaqar opened this issue Feb 28, 2025 · 1 comment · May be fixed by #5451
Labels
help wanted Extra attention is needed kind/feature new feature
Milestone

Comments

@muwaqar
Copy link

muwaqar commented Feb 28, 2025

Description:
I am going through the processDestination() code (linked below) and I see BackendTLSPolicy handling for Service and Backend destinations only. Seems there is no ds.TLS set for ServiceImport backends.

https://github.com/confluentinc/envoy-gateway/blob/main/internal/gatewayapi/route.go#L1270

Is this deliberate or an oversight?

Repro steps:
N/A

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

Logs:

Include the access logs and the Envoy logs.

@muwaqar muwaqar added the triage label Feb 28, 2025
@arkodg arkodg added help wanted Extra attention is needed kind/feature new feature labels Mar 1, 2025
@arkodg arkodg added this to the v1.4.0-rc.1 milestone Mar 1, 2025
@arkodg arkodg removed the triage label Mar 1, 2025
@nareddyt
Copy link
Contributor

nareddyt commented Mar 4, 2025

(after this is fixed) we should update the diagram in https://gateway.envoyproxy.io/docs/concepts/concepts_overview/ to reflect that BackendTLSPolicy can target a ServiceImport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants