Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8790] Add Utils for put header to Metadata to avoid duplicate data #8792

Merged

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Add Utils for put header to gRPC Metadata to avoid duplicate data.

Fixes #8790

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 47.34%. Comparing base (782da70) to head (feeac3f).

Files with missing lines Patch % Lines
.../apache/rocketmq/proxy/common/utils/GrpcUtils.java 0.00% 9 Missing ⚠️
...etmq/proxy/grpc/interceptor/HeaderInterceptor.java 0.00% 4 Missing ⚠️
...xy/grpc/interceptor/AuthenticationInterceptor.java 0.00% 3 Missing ⚠️
...mq/proxy/grpc/pipeline/AuthenticationPipeline.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8792      +/-   ##
=============================================
- Coverage      47.38%   47.34%   -0.04%     
+ Complexity     11557    11554       -3     
=============================================
  Files           1282     1283       +1     
  Lines          89864    89873       +9     
  Branches       11563    11565       +2     
=============================================
- Hits           42578    42550      -28     
- Misses         42038    42072      +34     
- Partials        5248     5251       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins changed the title [ISSUE #8790]Add Utils for put header to Metadata to avoid duplicate data. [ISSUE #8790] Add Utils for put header to Metadata to avoid duplicate data Oct 9, 2024
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 95b1c51 into apache:develop Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add Utils for put header to gRPC Metadata to avoid duplicate data.
4 participants