Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add Utils for put header to gRPC Metadata to avoid duplicate data. #8790

Closed
3 tasks done
dingshuangxi888 opened this issue Oct 8, 2024 · 0 comments · Fixed by #8792
Closed
3 tasks done

[Bug] Add Utils for put header to gRPC Metadata to avoid duplicate data. #8790

dingshuangxi888 opened this issue Oct 8, 2024 · 0 comments · Fixed by #8792

Comments

@dingshuangxi888
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Linux

RocketMQ version

develop

JDK Version

All Java version

Describe the Bug

The following code in org.apache.rocketmq.proxy.grpc.pipeline.AuthenticationPipeline#newContext will repeatedly insert AK information into the Metadata, which resulting in a memory leak.

if (StringUtils.isNotBlank(defaultAuthenticationContext.getUsername())) {
headers.put(GrpcConstants.AUTHORIZATION_AK, defaultAuthenticationContext.getUsername());
}

Steps to Reproduce

Send message with ACL 2.0 and gRPC client.

What Did You Expect to See?

The AK is unique in metadata no matter how many times the API calls.

What Did You See Instead?

The AK is unique in metadata no matter how many times the API calls.

Additional Context

No response

@dingshuangxi888 dingshuangxi888 changed the title [Bug] Fix gRPC ACL 2.0 PUT AK to Metadata duplicate [Bug] Add Utils for put header to Metadata to avoid duplicate data. Oct 8, 2024
@dingshuangxi888 dingshuangxi888 changed the title [Bug] Add Utils for put header to Metadata to avoid duplicate data. [Bug] Add Utils for put header to gRPC Metadata to avoid duplicate data. Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant