-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests verifying library is -w warning-clean #4550
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 20785 Passed, 1370 Skipped, 3m 44.19s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be changed in #4433 with this lines https://github.com/DataDog/dd-trace-rb/pull/4433/files#diff-a2d6d6d68e8af1a8701d9cbb5c926cbae65bd3292847196f7d29979db30cf2b6R53-R57
e519675
to
2ae0407
Compare
I removed the appsec change. |
2ae0407
to
d40f7cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4550 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 1396 1396
Lines 85838 85877 +39
Branches 4322 4334 +12
==========================================
+ Hits 83932 83962 +30
- Misses 1906 1915 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
What does this PR do?
Adds a test that no warnings (
ruby -v
) are emitted when the tracer is loaded (#4548, #4547, #4548)Motivation:
Customer feedback that they don't want tracer to emit warnings
Change log entry
None (warnings removed by the other PRs, this PR only adds test coverage)
Additional Notes:
How to test the change?
Tests are added in this PR