Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests verifying library is -w warning-clean #4550

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

p-datadog
Copy link
Member

What does this PR do?

Adds a test that no warnings (ruby -v) are emitted when the tracer is loaded (#4548, #4547, #4548)

Motivation:

Customer feedback that they don't want tracer to emit warnings

Change log entry
None (warnings removed by the other PRs, this PR only adds test coverage)

Additional Notes:

How to test the change?
Tests are added in this PR

@p-datadog p-datadog requested review from a team as code owners March 31, 2025 11:41
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Mar 31, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 31, 2025

Datadog Report

Branch report: warnings-test-coverage
Commit report: 6e73a1a
Test service: dd-trace-rb

✅ 0 Failed, 20785 Passed, 1370 Skipped, 3m 44.19s Total Time

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-datadog p-datadog force-pushed the warnings-test-coverage branch from e519675 to 2ae0407 Compare March 31, 2025 19:36
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Mar 31, 2025
@p-datadog
Copy link
Member Author

I removed the appsec change.

@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-04-03 10:05:39

Comparing candidate commit 6e73a1a in PR branch warnings-test-coverage with baseline commit 1e58013 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@p-datadog p-datadog force-pushed the warnings-test-coverage branch from 2ae0407 to d40f7cf Compare March 31, 2025 20:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (1e58013) to head (6e73a1a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1396     1396              
  Lines       85838    85877      +39     
  Branches     4322     4334      +12     
==========================================
+ Hits        83932    83962      +30     
- Misses       1906     1915       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anmarchenko anmarchenko requested review from Strech and y9v April 2, 2025 11:48
Copy link
Member

@y9v y9v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
@p-datadog p-datadog merged commit 83acab6 into master Apr 3, 2025
442 checks passed
@p-datadog p-datadog deleted the warnings-test-coverage branch April 3, 2025 12:18
@github-actions github-actions bot added this to the 2.14.0 milestone Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product dev/testing Involves testing processes (e.g. RSpec) integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants