Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning related to regular expression in AppSec #4548

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Mar 31, 2025

What does this PR do?
It fixes a following warning:

dd-trace-rb/lib/datadog/appsec/actions_handler/serializable_backtrace.rb:14: warning: character class has duplicated range: /\b([\w+:{2}]*\w+)?[#|.]?\b(\w+)\z/

Motivation:
We don't want any warnings to be triggered by our library code.

Change log entry
None. This change is internal.

Additional Notes:
None.

How to test the change?

ruby -W lib/datadog/appsec/actions_handler/serializable_backtrace.rb

@y9v y9v self-assigned this Mar 31, 2025
@y9v y9v requested a review from a team as a code owner March 31, 2025 08:26
@github-actions github-actions bot added the appsec Application Security monitoring product label Mar 31, 2025
@y9v y9v changed the title Fix a warnine related to regular expression in AppSec Fix a warning related to regular expression in AppSec Mar 31, 2025
@y9v y9v force-pushed the appsec-fix-regex-warning branch from 215ed8a to 48f0a70 Compare March 31, 2025 08:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (e239a85) to head (48f0a70).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4548      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1392     1392              
  Lines       84981    84981              
  Branches     4287     4287              
==========================================
- Hits        83093    83086       -7     
- Misses       1888     1895       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: appsec-fix-regex-warning
Commit report: 48f0a70
Test service: dd-trace-rb

✅ 0 Failed, 20784 Passed, 1373 Skipped, 3m 17.88s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-03-31 08:53:34

Comparing candidate commit 48f0a70 in PR branch appsec-fix-regex-warning with baseline commit e239a85 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@y9v y9v merged commit fda0cae into master Mar 31, 2025
442 of 443 checks passed
@y9v y9v deleted the appsec-fix-regex-warning branch March 31, 2025 09:19
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 31, 2025
@p-datadog
Copy link
Member

👍 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants