Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update file upload MIME types to use standard format #1757

Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix: update file upload MIME types to use standard format #1757

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
782a447
fix: update file upload MIME types to use standard format
hexart Jan 20, 2025
bbd7e37
add some comments to describe why and how
hexart Jan 20, 2025
3845027
Merge branch 'main' into fix-Remove-invalid-MIME-type-warning
hexart Jan 20, 2025
c6b749c
Merge branch 'main' into fix-Remove-invalid-MIME-type-warning
dokterbob Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion frontend/src/components/chat/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,27 @@ const Chat = () => {
const uploadFileRef = useRef(uploadFile);
const navigate = useNavigate();

// Update file upload MIME types to use standard format following Mozilla's guidelines: @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#unique_file_type_specifiers
// Instead of using '*/*' which may cause MIME type warnings, we specify exact MIME type categories:
// - 'application/*' - for general files
// - 'audio/*' - for audio files
// - 'image/*' - for image files
// - 'text/*' - for text files
// - 'video/*' - for video files
// This provides better type safety and clearer file type expectations.
const fileSpec = useMemo(
() => ({
max_size_mb:
config?.features?.spontaneous_file_upload?.max_size_mb || 500,
max_files: config?.features?.spontaneous_file_upload?.max_files || 20,
accept: config?.features?.spontaneous_file_upload?.accept || ['*/*']
accept: config?.features?.spontaneous_file_upload?.accept || {
'application/*': [], // All application files
'audio/*': [], // All audio files
'image/*': [], // All image files
'text/*': [], // All text files
'video/*': [] // All video files

}
}),
[config]
);
Expand Down
Loading