fix: update file upload MIME types to use standard format #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hexart
commented
Jan 20, 2025
hexart
commented
- Replace '/' with specific MIME type categories
- Add support for application, audio, image, text and video files
- Remove invalid MIME type warning
- Replace '*/*' with specific MIME type categories - Add support for application, audio, image, text and video files - Remove invalid MIME type warning
dosubot
bot
added
size:XS
dokterbob
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks! It took me a while to find out why this makes sense, until I landed through Drop zone's documentation at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#unique_file_type_specifiers
Perhaps we could add some comment describing the why and how of this, referring to aforementioned (or some equivalent) URL?
It's nice to be kind to our future selves! ;)
dokterbob
added
the
blocked
dosubot
bot
added
size:S
dokterbob
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.