Custom almanac #357
Merged
Custom almanac #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addFact method is stright from the engine class. It's able to either add a fact with a name and value / implementation or add a fact as a fact subclass.
Move the Almanac Initialization into the engine class. This will allow it to take user supplied Almanacs correctly.
Support for passing a custom almanac to the run options in the engine.
CacheControl
approved these changes
Nov 8, 2023
tea-artist
reviewed
Apr 19, 2024
|
|
||
| ```js | ||
| // constant facts: | ||
| engine.addFact('speed-of-light', 299792458) |
There was a problem hiding this comment.
Looks like a mistake, engine.addFact should be almanac.addFact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a generic suggestion to resolve #314
Rather than having the Almanac class be completely hidden except in event properties we move to having the Almanac be an option that can be passed into the run call. This allows for extensions of Almanacs that can do things that the standard Almanac can't do.
In order to support this properly a new addFact method was added to the Almanac that replaces the addRuntimeFact method but also allows dynamic facts to be added.