-
Notifications
You must be signed in to change notification settings - Fork 492
Feature/add value pipes support #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add value pipes support #314
Conversation
- Evaluate available pipes upon condition evaluation. - Add default pipes. e.g. scale, add, sub ...etc.
@CacheControl I need your review on this if you got some time. |
i think this feature is out of the scope of rule engine. it is nice to have.... but it will break the pure rule engine concept. pipes will move as to the STATE MACHINE zone |
re-opening for visibility and to hear more opinions on this feature; I can see it being valuable for certain situations. |
@CacheControl my thought on this is that we could make the Over all what I think we should focus on for improvements is less new features and more ways to plug in new features by providing points at which other code can step in. |
@CacheControl see #356 for part of the work to support something like this. The ability to plug in custom condition classes in order to add arbitrary logic. In this case the support for pipes would need to live in the condition. |
in my work place we was need to add some changes in the source code in order to get data on array conditions - to know the index inside the array that fail the condition check. so we pass and expose the "this" of the inner rule object .. |
Add support for pipes to manipulate fact values.
Here is an example of using a pipe to transform the balance currency from euros to USD and another one for applying a discount to the product.