Support compiler options #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Regarding last compiler options discussion here is the findings |
asatklichov
reviewed
Feb 12, 2025
msujew
force-pushed
the
feature/msujew/compiler-options
branch
from
7796e8b to
cc84b51
Compare
msujew
force-pushed
the
feature/msujew/compiler-options
branch
from
6aaefba to
f03ab7a
Compare
Signed-off-by: Mark Sujew <mark.sujew@typefox.io>
msujew
force-pushed
the
feature/msujew/compiler-options
branch
from
f03ab7a to
a017f92
Compare
|
@asatklichov I believe I've resolved most issues. Two are left:
|
asatklichov
reviewed
Mar 12, 2025
| positionTracking: "full", | ||
| }); | ||
|
|
||
| class Parser extends EmbeddedActionsParser { |
There was a problem hiding this comment.
Can we rename this Parser to specific like COParser or CompilerOptionsParser? If it is intented to be generic parser then better keep it in 'parser' folder. With new model I expect this will be changed anyway.
There was a problem hiding this comment.
Sure, it's a good idea to rename it. But yes, you're right - it will eventually be moved into the main parser once the migration is complete.
KUGDev
reviewed
Apr 1, 2025
| @@ -0,0 +1,142 @@ | |||
| import { describe, test, expect } from "vitest"; | |||
There was a problem hiding this comment.
Please add the copyright header
KUGDev
approved these changes
Apr 1, 2025
|
Blocked by #68 right now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Provides an initial implementation of the compiler options feature of PL/I. This includes:
*PROCESSstatement of filespgm_conf.jsonfile in the workspace root (this can be changed later).What is still left to do:
ORandNOTdo not work yet, as they require the preprocessor PR to land first (similar with theNAMESoption)pgm_conf.jsondoes not align to the schema of the other zowe language servers yet. We will address this in a later PR.