Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input traits implementation for Graphemes #690

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Add input traits implementation for Graphemes #690

merged 3 commits into from
Oct 26, 2024

Conversation

Hedgehogo
Copy link
Contributor

This is to prevent constructs like this ̲0 from being treated as a symbol followed by an number.

P.S. Extended grapheme clusters are being used.

zesterer
zesterer reviewed Oct 26, 2024
View reviewed changes
Copy link
Owner

@zesterer zesterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I broadly agree that this is a good thing to merge. Maybe it could be moved to text.rs though?

@zesterer
Copy link
Owner

Thanks for the PR!

@zesterer zesterer merged commit b748447 into zesterer:main Oct 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zesterer zesterer zesterer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hedgehogo @zesterer