Problems: using Wine requires system tuning, ZMQ_BINDTODEVICE not draft #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: document it in the INSTALL file Fixes zeromq#2638
bluca
changed the title
Solution: move definition in the DRAFT section of the header
Solution: apply the option outside of the send/recv_enabled blocks so that it is used for all types of UDP sockets
jimklimov
approved these changes
Aug 1, 2017
| @@ -368,7 +368,6 @@ ZMQ_EXPORT const char *zmq_msg_gets (const zmq_msg_t *msg, const char *property) | |||
| #define ZMQ_VMCI_BUFFER_MAX_SIZE 87 | |||
| #define ZMQ_VMCI_CONNECT_TIMEOUT 88 | |||
| #define ZMQ_USE_FD 89 | |||
| #define ZMQ_BINDTODEVICE 90 | |||
There was a problem hiding this comment.
Perhaps add a comment that numbering continues elsewhere? Wouldn't an enum be better to avoid conflicts (e.g. two values later with same numbers)?
But even if so, this is a subject for subsequent PR :)
There was a problem hiding this comment.
We intentionally avoid enums as it's way, way too easy to break ABI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: document it in the INSTALL file
Fixes #2638