Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop to v1.74.0 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 27, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) '1.73.0' -> '1.74.0' age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.74.0

Compare Source

New features
Bug fixes
  • #​13969: Fix a false positive for Lint/SharedMutableDefault when capacity keyword argument is used. ([@​koic][])
  • #​13945: Fix a false positive for Style/DoubleNegation when calling define_method/define_singleton_method with a numblock. ([@​earlopain][])
  • #​13971: Fix false alarm for config obsoletion. ([@​koic][])
  • #​13960: Fix a false negative for Lint/ReturnInVoidContext when returning out of a block. ([@​earlopain][])
  • #​13947: Fix a false negative for Lint/UselessConstantScoping for constants defined in class << self. ([@​earlopain][])
  • #​13949: Fix a false negative for Lint/NonLocalExitFromIterator with numblocks. ([@​earlopain][])
  • #​13975: Fix false positives for Style/RedundantCurrentDirectoryInPath when using a complex current directory path in require_relative. ([@​koic][])
  • #​13963: Fix wrong autocorrect for Lint/LiteralAsCondition when the literal is followed by return, break, or next. ([@​earlopain][])
  • #​13946: Fix some false positives for Style/MethodCallWithArgsParentheses with EnforcedStyle: omit_parentheses style and numblocks. ([@​earlopain][])
  • #​13950: Fix sporadic errors about rubocop-rails or rubocop-performance extraction, even if they are already part of the Gemfile. ([@​earlopain][])
  • #​13981: Prevent redundant plugin loading when a duplicate plugin is specified in an inherited config. ([@​koic][])
  • #​13965: Update Lint/RedundantCopDisableDirective to register an offense when cop names are given with improper casing. ([@​dvandersluis][])
  • #​13948: Fix wrong autocorrect for Style/RescueModifier when using parallel assignment and the right-hand-side is not a bracketed array. ([@​earlopain][])
Changes
  • #​12851: Add EnforcedStyleForClasses and EnforcedStyleForModules configuration options to Style/ClassAndModuleChildren. ([@​dvandersluis][])
  • #​13979: Add Mode: conservative configuration to Style/FormatStringToken to make the cop only register offenses for strings given to printf, sprintf, format, and %. ([@​dvandersluis][])
  • #​13977: Allow TLS1_1 and TLS1_2 by default in Naming/VariableNumber to accommodate OpenSSL version parameter names. ([@​koic][])
  • #​13967: Make Lint/RedundantTypeConversion aware of redundant to_d. ([@​koic][])

v1.73.2

Compare Source

Bug fixes
  • #​13942: Fix incorrect disabling of departments when inheriting configuration. ([@​koic][])
  • #​13766: Fix false positives for Style/InverseMethods when using any? or none? with safe navigation operator. ([@​koic][])
  • #​13938: Fix false positives for Style/RedundantCondition when a variable or a constant is used. ([@​koic][])
  • #​13935: Fix a false negative for Style/RedundantFreeze when calling methods that produce frozen objects with numblocks. ([@​earlopain][])
  • #​13928: Fix end pattern with unmatched parenthesis: / (RegexpError) on Ruby 3.2.0. ([@​dvandersluis][])
  • #​13933: Fix wrong autocorrect for Style/KeywordParametersOrder when the arguments are on multiple lines and contain comments. ([@​earlopain][])
Changes

v1.73.1

Compare Source

Bug fixes
  • #​13920: Fix an error for Lint/MixedCaseRange when /[[ ]]/ is used. ([@​koic][])
  • #​13912: Fix wrong autocorrect for Lint/EmptyConditionalBody when assigning to a variable with only a single branch. ([@​earlopain][])
  • #​13913: Fix false positives for Style/RedundantCondition when using when true is used as the true branch and the condition is not a predicate method. ([@​koic][])
  • #​13909: Fix false positive with Layout/ClosingParenthesisIndentation when first parameter is a hash. ([@​tejasbubane][])
  • #​13915: Fix writing generics type of rbs-inline annotation for nested class in Style/CommentedKeyword. ([@​dak2][])
  • #​13916: Fix Lint/LiteralAsCondition acting on the right hand side of && nodes. ([@​zopolis4][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@yegor256
Copy link
Owner

@rultor please, try to merge, since 8 checks have passed

@rultor
Copy link
Collaborator

rultor commented Feb 27, 2025

@rultor please, try to merge, since 8 checks have passed

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
Copy link
Collaborator

rultor commented Feb 27, 2025

@rultor please, try to merge, since 8 checks have passed

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 1min).

f4b0a34d6583: Pull complete
4f4fb700ef54: Pull complete
bec34e87297d: Pull complete
523ddcc2758f: Pull complete
906376b8e79c: Pull complete
56133c07703d: Pull complete
Digest: sha256:3d441ebe75b53f50776ca078922c791049360d98845aae15c120e943b7817e3b
Status: Downloaded newer image for yegor256/rultor-ruby:latest
docker.io/yegor256/rultor-ruby:latest
+ docker ps --filter=status=exited
+ grep --quiet '\syegor256_donce_16\s*$'
+ ls -al .
total 52
drwx------  3 ubuntu ubuntu 4096 Feb 27 14:29 .
drwxrwxrwt 12 root   root   4096 Feb 27 14:29 ..
-rwxrwxr-x  1 ubuntu ubuntu 2089 Feb 27 14:29 end.sh
-rwxrwxr-x  1 ubuntu ubuntu  490 Feb 27 14:29 entry.sh
-rw-rw-r--  1 ubuntu ubuntu    5 Feb 27 14:29 pid
drwxrwxr-x  7 ubuntu ubuntu 4096 Feb 27 14:29 repo
-rw-rw-r--  1 ubuntu ubuntu   81 Feb 27 14:29 rubygems.yml
-rwxrwxr-x  1 ubuntu ubuntu 9114 Feb 27 14:29 run.sh
-rw-rw-r--  1 ubuntu ubuntu  543 Feb 27 14:29 script.sh
-rw-rw-r--  1 ubuntu ubuntu 6776 Feb 27 14:30 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-2FPz:/main --env=head=git@github.com:yegor256/donce.git --env=pull_id=16 --env=fork=git@github.com:yegor256/donce.git --env=fork_branch=renovate/rubocop-1.x --env=head_branch=master '--env=pull_title=Update dependency rubocop to v1.73.1' --env=author=yegor256 '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:yegor256/donce.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=16'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:yegor256/donce.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=renovate/rubocop-1.x'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=Update dependency rubocop to v1.73.1'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=yegor256'\''\'\'''\'''\'' '\'';'\'' '\''pdd -f /dev/null'\'' '\'';'\'' '\''bundle install --no-color'\'' '\'';'\'' '\''DONCE_SUDO=true bundle exec rake'\'' '\'';'\'' )' --hostname=docker --privileged --net=host --dns 8.8.8.8 --add-host docker:127.0.0.1 --memory=8g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-2FPz/cid -w=/main -v /var/run/docker.sock:/var/run/docker.sock --name=yegor256_donce_16 yegor256/rultor-ruby /main/entry.sh
WARNING: Your kernel does not support OomKillDisable. OomKillDisable discarded.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
++ awk -F : '$3 > 100 { print $1 }'
++ cat /etc/group
+ for g in $(cat /etc/group | awk  -F  ':' '$3 > 100 { print $1 }')
+ usermod -a -G nogroup r
+ for g in $(cat /etc/group | awk  -F  ':' '$3 > 100 { print $1 }')
+ usermod -a -G ssh r
+ for g in $(cat /etc/group | awk  -F  ':' '$3 > 100 { print $1 }')
+ usermod -a -G r r
+ usermod -s /bin/bash r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.cache /root/.gemrc /root/.local /root/.profile /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./rubygems.yml ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ cat /home/r/script.sh
#!/bin/bash
set -e
set -o pipefail
if [ -e /home/r/.profile ]; then source /home/r/.profile; fi
shopt -s expand_aliases
alias 'sudo=sudo -i'
export HOME=/home/r
cd "${HOME}/repo"
export 'head=git@github.com:yegor256/donce.git' ; export 'pull_id=16' ; export 'fork=git@github.com:yegor256/donce.git' ; export 'fork_branch=renovate/rubocop-1.x' ; export 'head_branch=master' ; export 'pull_title=Update dependency rubocop to v1.73.1' ; export 'author=yegor256' ; pdd -f /dev/null ; bundle install --no-color ; DONCE_SUDO=true bundle exec rake ;
+ su --login r --command /home/r/script.sh
/home/r/script.sh: line 9: pdd: command not found
container 1143d21cbcaba8b23ff1d3b0a30db92e00fc03a9151c21da5ae03336f4e5bd84 is dead
Thu Feb 27 14:30:34 UTC 2025

@renovate renovate bot changed the title Update dependency rubocop to v1.73.1 Update dependency rubocop to v1.73.2 Mar 4, 2025
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from d8aff9b to c34bfbe Compare March 4, 2025 09:20
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from c34bfbe to 5fce02a Compare March 13, 2025 13:24
@renovate renovate bot changed the title Update dependency rubocop to v1.73.2 Update dependency rubocop to v1.74.0 Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants