Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make podspec work with static libraries. #29

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Make podspec work with static libraries. #29

merged 1 commit into from
Dec 8, 2017

Conversation

chrsmys
Copy link
Contributor

@chrsmys chrsmys commented Dec 8, 2017

No description provided.

@chrsmys chrsmys requested a review from iMacHumphries December 8, 2017 20:30
iMacHumphries
iMacHumphries suggested changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@iMacHumphries iMacHumphries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the read me with this?

@chrsmys
Copy link
Contributor Author

chrsmys commented Dec 8, 2017

We are still recommending that everyone "use_frameworks!". I want to make sure that it is actually fixed before we take away the warning.

@chrsmys chrsmys merged commit ea419b3 into develop Dec 8, 2017
@iMacHumphries iMacHumphries deleted the feature/updatePodspec1.0.2 branch December 8, 2017 20:37
@chrsmys
Copy link
Contributor Author

chrsmys commented Jan 20, 2018

This should fix issue #33 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacHumphries iMacHumphries iMacHumphries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrsmys @iMacHumphries