[css-align] justfy-items accepts 'legacy' and drops support for 'auto' #9400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 6, 2018
Build PASSEDStarted: 2018-02-09 00:49:20 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-903162
branch
2 times, most recently
from
b0f5539 to
3381b37
Compare
The syntax of the 'justify-items' property accepts a new 'legacy' value, replacing the 'auto' value which is now parsed as invalid. w3c/csswg-drafts#1318 This change affects also to the 'place-items' shorthand, which doesn't accept 'auto' and, for the time being, neither 'legacy'. Link to the intent-to-ship-and-remove request: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer Bug: 726147, 726148 Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350 Reviewed-on: https://chromium-review.googlesource.com/903162 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#535593}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-903162
branch
from
3381b37 to
248ad8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.
w3c/csswg-drafts#1318
This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.
Link to the intent-to-ship-and-remove request:
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer
Bug: 726147, 726148
Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350
Reviewed-on: https://chromium-review.googlesource.com/903162
Commit-Queue: Javier Fernandez jfernandez@igalia.com
Reviewed-by: Christian Biesinger cbiesinger@chromium.org
Reviewed-by: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#535593}