Skip to content

[css-grid] [css-sizing] links to column-gap #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

ewilligers
Copy link
Contributor

@ewilligers ewilligers commented May 10, 2019

css-grid-2 refers to css-align-3 column-gap (and row-gap).

css-sizing-4 refers to css-align-3 column-gap (and css-multicol-1 column-count).

@ewilligers ewilligers added css-sizing-4 css-grid-2 Subgrid; Current Work labels May 10, 2019
@ewilligers ewilligers requested a review from tabatkins May 24, 2019 00:08
@ewilligers
Copy link
Contributor Author

@jensimmons please review

@ewilligers ewilligers requested a review from jensimmons May 24, 2019 00:25
css-grid-2 refers to css-align-3 column-gap (and row-gap).

css-sizing-4 refers to css-align-3 column-gap (and css-multicol-1 column-count).
@ewilligers
Copy link
Contributor Author

Updated PR due to #3641 decision.

Copy link
Contributor

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@ewilligers ewilligers merged commit d9e91be into w3c:master Jun 18, 2019
@ewilligers ewilligers deleted the column-gap branch June 18, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-grid-2 Subgrid; Current Work css-sizing-4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants