Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): nav height cannot be a fixed number #2663

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix(theme): nav height cannot be a fixed number #2663

merged 2 commits into from
Jul 21, 2023

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Jul 21, 2023 •
edited
Loading

If I customize the height of --vp-nav-height to 80, but the existing version uses a fixed nav height of 64, some of the styles will be problematic.

@zonemeen zonemeen marked this pull request as draft July 21, 2023 03:26
@zonemeen zonemeen marked this pull request as ready for review July 21, 2023 04:11
@brc-dd brc-dd merged commit 3912951 into vuejs:main Jul 21, 2023
@zonemeen zonemeen deleted the refactor/nav-variant branch July 21, 2023 08:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brc-dd brc-dd brc-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zonemeen @brc-dd