fix: createContentLoader generates invalid url when sets srcDir
#2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll get back on this. Need to check on some projects as this will be a breaking change. Seems right though. |
|
@brc-dd, when will this be merged? This is causing a weird issue where the logo is no longer showing if I set a custom |
|
@SapneshNaik What does this have to do with logo? |
|
@brc-dd the Logo URL (set in the |
|
@SapneshNaik That isn't related to this PR. Please create a separate issue for that. |
|
Agree that this change makes sense, I don't see any reason for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2540
closes #2462