Skip to content

feat(client): Config nav support custom target #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

kev1nzh37
Copy link
Contributor

closes #1595

@watonyweng
Copy link

Hi @kev1nzh37, i think the value of target should be limited to [_self, _blank, _parent, _top], please refer to here for more information.

@kev1nzh37
Copy link
Contributor Author

Hi @kev1nzh37, i think the value of target should be limited to [_self, _blank, _parent, _top], please refer to here for more information.

I have considered this, but will it affect the following situations.

<iframe name="child1" />
<iframe name="child2" />

// vitepress in child1 
<a href="http://www.child1.com/docs1" target="child2">Open</a>

Hope to get more suggestions, thanks.

@brc-dd
Copy link
Member

brc-dd commented Nov 30, 2022

Allow overriding rel too as people might have security concerns.

@brc-dd
Copy link
Member

brc-dd commented Feb 25, 2023

Hey, merged this as #1993. Had to rebase due to conflicts.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config nav support custom target
3 participants