-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with custom theme and no css #209
Comments
Good catch! Thanks for the report. I think your fix is reasonable. If there're no css files, we should just stop requiring it. Would you like to make a PR? 👀 |
Sure, I can do that |
domnantas
pushed a commit
to domnantas/vitepress
that referenced
this issue
Feb 11, 2021
kiaking
added a commit
that referenced
this issue
Apr 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
I started building a custom theme and haven't imported any css to
index.js
yet. Runningvitepress build
throws an error:render.js:53
is trying to getcssChunk.fileName
:but it is undefined since there are not css chunks.
The same happens if you try to import an empty .css file to
index.js
.vitepress dev
does not throw the error.To Reproduce
Steps to reproduce the behavior:
(notice how there are no .css imports in the docs either)
vitepress build
Reproduction repo: https://github.com/domnantas/domnantas.lt/tree/no-css-chunks
Expected behavior
Build should not fail when building without css
System Info
Additional context
would fix this, but maybe there are better ways
The text was updated successfully, but these errors were encountered: