Skip to content

Buttons shouldn't receive cursor: pointer when disabled #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Volker-E opened this issue Sep 8, 2022 · 0 comments · Fixed by #1300
Closed
3 tasks done

Buttons shouldn't receive cursor: pointer when disabled #1299

Volker-E opened this issue Sep 8, 2022 · 0 comments · Fixed by #1300
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@Volker-E
Copy link
Contributor

Volker-E commented Sep 8, 2022

Describe the bug

As of VitePress v1.0.0-alpha.4 buttons receive cursor: pointer no matter if they are disabled or not by this base.css rule.

Reproduction

See https://doc.wikimedia.org/codex/main/components/button.html and disable the button.

Expected behavior

A disabled button should have default cursor.

System Info

VitePress v1.0.0-alpha.4

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@Volker-E Volker-E added the bug: pending triage Maybe a bug, waiting for confirmation label Sep 8, 2022
Volker-E added a commit to Volker-E/vitepress that referenced this issue Sep 8, 2022
@Volker-E
Use pointer cursor only on enabled button
7d25feb 
Fix vuejs#1299
@Volker-E Volker-E mentioned this issue Sep 8, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pointer cursor only on enabled button Volker-E/vitepress
1 participant
@Volker-E