feat: add --eslint-with-oxlint and --prettier feature flags
#682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b51c033.
TBH this isn't ideal. The only bottleneck in the build job is the snapshot step, moving it to the verification jobs defeats the purpose of having a separate build job. I'll fix it later by trying to use tar.
cexbrayat
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with adding
--eslint-with-oxlintbut found it didn't make sense without a standalone--prettierflag.To achieve that I had to duplicate some logic from
@vue/create-eslint-configbut I think it's acceptable as it's just a few lines of templates, the complex logic about eslint integration still resides in@vue/create-eslint-config.The downside is that the playground got bloated by a lot. I tried to speed up the CI, but it's still slower than previous and there isn't much I can do here, there's an inherent complexity in running tests on more than a thousand projects.