Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Core] using cached vocab_size for Structured Outputs #14630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Mar 11, 2025

Previously, we obtained vocab_size for xgrammar from hf_text_config directly.

However, in the recent version of xgrammar, the detected vocab_size now include special_tokens, in which raises the issue found in #14534

By calculating the vocab size, it ensures supporting custom tokenizers with the like of Olmo, etc.

@aarnphm aarnphm requested review from mgoin and russellb as code owners March 11, 2025 17:34
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

self.vllm_config = vllm_config

tokenizer = tokenizer_group.get_lora_tokenizer(None)
self.vocab_size = len(tokenizer.get_vocab())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use len(tokenizer), which is cached: https://github.com/vllm-project/vllm/blob/main/vllm/transformers_utils/tokenizer.py#L101

Or it might be better to use tokenizer.max_token_id. I have seen cases where the vocab size is actually larger than the number of tokens in the tokenizer since some were removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need @Ubospica confirmation here.

@aarnphm
Copy link
Collaborator Author

aarnphm commented Mar 11, 2025

Will add tests once #14625 is merged

@aarnphm aarnphm force-pushed the v1/molmo-aria-support-vocab branch 2 times, most recently from 8fa2aa6 to a53c058 Compare March 12, 2025 00:20
@aarnphm aarnphm changed the title [V1][Core] calculating vocab_size from given tokenizer [V1][Core] using cached vocab_size for Structured Outputs Mar 12, 2025
Copy link

mergify bot commented Mar 12, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 12, 2025
aarnphm added 2 commits March 12, 2025 03:49
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm force-pushed the v1/molmo-aria-support-vocab branch from 689278a to 8872481 Compare March 12, 2025 07:50
@mergify mergify bot removed the needs-rebase label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants