Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that TP > 1 is not supported for Mamba2 if Quantization is Enabled. #14617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabianlim
Copy link
Contributor

@fabianlim fabianlim commented Mar 11, 2025

Currently there is a bug in the logic that will fail to load the model if the mamba2 layer is quantised. This is because quantised layers have parameters of type ModelWeightParameter that do not allow the weight_loader to be modified, which is our current strategy of handling TP for the mamba2 in_proj, see #13660.

This PR prevents an Attribute Error

AttributeError: property 'weight_loader' of 'ModelWeightParameter' object has no deleter

from being thrown, in the case when using quant layers with TP=1. And also, it prevents TP > 2 from being used if quant layers are present

cc: @tlrmchlsmth

Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant