Enforce that TP > 1 is not supported for Mamba2 if Quantization is Enabled. #14617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug in the logic that will fail to load the model if the mamba2 layer is quantised. This is because quantised layers have parameters of type
ModelWeightParameter
that do not allow theweight_loader
to be modified, which is our current strategy of handling TP for the mamba2in_proj
, see #13660.This PR prevents an Attribute Error
from being thrown, in the case when using quant layers with TP=1. And also, it prevents TP > 2 from being used if quant layers are present
cc: @tlrmchlsmth