Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Data parallel example might fail if the users script initializes torch.cuda #14598

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jackmin801
Copy link

@Jackmin801 Jackmin801 commented Mar 11, 2025

This PR moves the setting of CUDA_VISIBLE_DEVICES to the main proc instead of having them set at the start of the target function. This prevents bugs caused by modifications to the script that initialize torch.cuda (e.g. importing flash attention)

Signed-off-by: Jackmin801 <ongjackm@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 11, 2025
Signed-off-by: Jackmin801 <ongjackm@gmail.com>
@Jackmin801
Copy link
Author

This PR didnt make any dependency changes so the docs build failure shouldnt be related

Downloading soupsieve-2.6-py3-none-any.whl (36 kB)
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    unknown package:
        Expected sha256 97787ff1fa3256a3eef9eda523a63dbf299f7b47e053cfcf684a1c2a8380c912
             Got        49b91c5c24ba4509dae434f256190740c6754b045cc5650ecf370a75199c147c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant