-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][TPU][V1] Disable StructuredOutputManager
import on TPU
#14573
[Bugfix][TPU][V1] Disable StructuredOutputManager
import on TPU
#14573
Conversation
Signed-off-by: NickLucche <nlucches@redhat.com>
StructuredOutputManager
import on TPU
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: NickLucche <nlucches@redhat.com>
StructuredOutputManager
import on TPUStructuredOutputManager
import on TPU
class StructuredOutputManager: | ||
|
||
def __init__(self, *args, **kwargs): | ||
pass | ||
|
||
def __getattr__(self, name): | ||
return lambda *args, **kwargs: None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll push something now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an alternative: #14575
Why not just install triton? |
The triton README doesn't list it as supported, so unless that's wrong, that doesn't sound ideal. My PR here will handle this more cleanly, assuming we don't expect this feature to work on TPU right now. #14575 |
V1 Engine on TPU is currently broken as
StructuredOutputManager
appears to have a hard dependency ontriton
, failing on server startup with:Open to any way to more gracefully solve this (quickly), especially with an impl that makes mypy happy (current one does not).