Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permute/unpermute kernel for moe optimization #14568

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CalebDu
Copy link

@CalebDu CalebDu commented Mar 10, 2025

moe_permute kernel expands and oreders token in activation to gather uncontinuous tokens for each expert. And then call grouped-gemm for moe speedup.
moe_unpermute kernel reduces expanded grouped-gemm output and scales with topk_weight.
image

This implementation refers to moe kernel in tensorrt-llm in archive https://github.com/BBuf/tensorrt-llm-moe/tree/master.
Currently, unsupport Expert-Parallelism with expert_map, will follow up with updates.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 10, 2025
@gzy19990617
Copy link

请问这个算子是为后面做group_gemm做准备工作嘛

@CalebDu
Copy link
Author

CalebDu commented Mar 12, 2025

请问这个算子是为后面做group_gemm做准备工作嘛

yes

@gzy19990617
Copy link

gzy19990617 commented Mar 12, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants