-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vlib: initial addition of x.encoding.asn1
#22783
Conversation
encoding/asn1
module to the experimental vlib namespacex.encoding.asn1
Can you please also convert some of the Having internal tests is convenient for testing the private parts of a module, but having ordinary tests, is also important, because they test the public API, and can also serve as additional examples of the usage, that are compiled and checked by the CI (the .v programs in the vlib/x/encoding/asn1/examples/ folder are not checked at all - as far as the CI is concerned they are just part of an |
Sure, i would add it at next iteration |
Thanks for the help, review and discussion . Thanks for merging it |
This is a rather big addition to the experimental vlib namespace. This module is marked as an experimental, inspired by the
go
and somerust
version of similar library, the exported api its rather big.This PR includes the docs, (maybe getting updates in the next iteration) that describes some parts of the module.
The simple benchmark also included in the
bench
dir, with the result (in my gitpod account)Regular benchmark produces this result:
Built with
-prod
flag and rerun the benchThe go version of benchmark produces following result:
The result with
-prod
flag is on par with the go result, even behind it.Please, give its a review, feedback, look or tries.
Best regards,
Huly®: V_0.6-21229