-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): open in IDE and error styles #1039
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
When I tried locally on macOS, after making a test fail and pressing the
Is there something else I need to setup so VS Code is picked up? About the styles, could the icon color have more contrast so it is accessible? We also have an |
@patak-dev the error comes from vite, vitest doesn't handle the Vite is using this library https://github.com/yyx990803/launch-editor from Evan |
We don't need tooltip listeners, the floating tooltip lib works also with focus and blur events |
Moved the
useCodeError
logic to theViewEditor.vue
component fromerror.ts
module, we would need to include@unocss-include
on theerror.ts
module to style the elements created.Anyway, on stackblitz I cannot make it working (missing links, it seems using oldest version), tested with
0.7.11
and0.7.12
but still not working, it seems stackblitz doing strange things, for example:taze
not showingvitest 0.7.12
, I need to runtaze major
.The repo I use with
0.7.12
with almost all core tests included: https://stackblitz.com/edit/vitejs-vite-nfjsbi