refactor: importAnalysisBuild
#19723
Open
+371
−362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
force-pushed
the
refactor-import-analysis-build
branch
from
154314e to
4098d6f
Compare
privatenumber
commented
Mar 26, 2025
privatenumber
force-pushed
the
refactor-import-analysis-build
branch
3 times, most recently
from
e5912cc to
0d85f7d
Compare
privatenumber
force-pushed
the
refactor-import-analysis-build
branch
6 times, most recently
from
309a0f4 to
aaa2273
Compare
sapphi-red
reviewed
Mar 28, 2025
privatenumber
force-pushed
the
refactor-import-analysis-build
branch
8 times, most recently
from
62ce4aa to
0325471
Compare
sapphi-red
previously approved these changes
Mar 28, 2025
privatenumber
force-pushed
the
refactor-import-analysis-build
branch
2 times, most recently
from
0958fd6 to
66cd77e
Compare
|
With this refactor, I also have a follow up perf optimization to de-duplicate the chunk registry: |
privatenumber
force-pushed
the
refactor-import-analysis-build
branch
from
66cd77e to
2496007
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulling out some minor refactors from #19722