Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in the image repository for metallb deployments #699

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

aditya2803
Copy link
Contributor

Summary

The metallb images have shifted the image repositories from docker.io to quay.io. This necessitates a change in the kubectl apply -f commands used in the vHive setup for deploying the metallb pods.

Implementation Notes ⚒️

  • The main change is in the image name for the metallb deployments. The original images were docker.io based, which have since changed to quay.io. Thus, I created new yaml files with the updated images, and then used these in the kubectl apply -f commands, replacing the original file.

External Dependencies 🍀

Breaking API Changes ⚠️

Simply specify none (N/A) if not applicable.

Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we retrieve the manifests by network? we don't plan to modify them hence it is easier to maintain the versioning this way

@aditya2803
Copy link
Contributor Author

Sure. However, on network there are a lot of changes, apart from the image name, for these deployments. Is it okay to test it out and if working, use the updated yamls on the metallb Github?

@ustiugov
Copy link
Member

Sure. However, on network there are a lot of changes, apart from the image name, for these deployments. Is it okay to test it out and if working, use the updated yamls on the metallb Github?

@aditya2803
Ease of maintaining is preferred, and fetching released manifests is tracking 2 lines of code as opposed to large YAML files where anything can go wrong. Can you change the fix to use released manifests?

@aditya2803
Copy link
Contributor Author

I understand. I will use the yaml files from an active branch (https://github.com/metallb/metallb/tree/v0.12). I tested it out, it was working okay. It has the updated quay.io image names.

@ustiugov
Copy link
Member

@aditya2803 thank you. can you update the files in this PR?

@aditya2803
Copy link
Contributor Author

@ustiugov Done.

@ustiugov
Copy link
Member

please use rebase interactive to squash 6 commits into one and sign it.

The metallb deployment images have moved to quay.io from docker.io. Updating the manifests to get the updated images.

Signed-off-by: Aditya Ravishankar <adityaravishankar28@gmail.com>
@aditya2803
Copy link
Contributor Author

Done. Could you let me know if it looks okay now? This is my first time, so having a little trouble with the technicalities.

@cvetkovic
Copy link
Contributor

LGTM!

@ustiugov ustiugov merged commit abf98da into vhive-serverless:main Mar 20, 2023
@ustiugov
Copy link
Member

@aditya2803 thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants